-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Button-fluid] Adding 3:1 border between touching buttons #5638
Comments
We need @mjabbink and @jeanservaas input on this one. |
Can we see this in context of a layout/usecase? In theory I have not issue with this but need to see more context. |
I like this and I want to do it in our next release, and I want to add it to button guidance now because we're getting tons of questions about this. This update not only adds clarity and contrast accessibility but in the dark themes, it will prevent the primary and secondary colors from vibrating. But @shixiedesign I have one question, why not just use the subtle border token rather than going cool gray? |
Agree on both. I don’t think the need is there for cool grey. Unless of course we switched all Grey to Cool Grey. |
Status: ready for development. Dev tasks:
Design tasks:
|
Closing because this has been added 👍🏻 |
The official docs says this update is not yet made. Maybe someone can update the docs?
|
Summary
Suggestion is to consider adding
gray-20, 1 px, solid
border between fluid primary and secondary buttons.This feature will add a 3:1 distinction between the two UI elements. It's a recommended feature to improve accessibility in data vis (advised by Michael Gower), although there are no clear requirements for UI to do the same, the logic applies as the two buttons should appear to users as distinct, and both interactive.
Exploration
The text was updated successfully, but these errors were encountered: