Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Button-fluid] Adding 3:1 border between touching buttons #5638

Closed
shixiedesign opened this issue Mar 16, 2020 · 7 comments
Closed

[Button-fluid] Adding 3:1 border between touching buttons #5638

shixiedesign opened this issue Mar 16, 2020 · 7 comments
Assignees
Labels
component: button proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: enhancement 💡

Comments

@shixiedesign
Copy link
Contributor

shixiedesign commented Mar 16, 2020

Summary

Suggestion is to consider adding gray-20, 1 px, solid border between fluid primary and secondary buttons.

This feature will add a 3:1 distinction between the two UI elements. It's a recommended feature to improve accessibility in data vis (advised by Michael Gower), although there are no clear requirements for UI to do the same, the logic applies as the two buttons should appear to users as distinct, and both interactive.

Exploration

image

@aledavila aledavila added the proposal: open This request has gone through triaging. We're determining whether we take this on or not. label Mar 17, 2020
@aagonzales
Copy link
Member

We need @mjabbink and @jeanservaas input on this one.

@mjabbink
Copy link

mjabbink commented May 8, 2020

Can we see this in context of a layout/usecase? In theory I have not issue with this but need to see more context.

@jeanservaas
Copy link
Collaborator

I like this and I want to do it in our next release, and I want to add it to button guidance now because we're getting tons of questions about this. This update not only adds clarity and contrast accessibility but in the dark themes, it will prevent the primary and secondary colors from vibrating.

But @shixiedesign I have one question, why not just use the subtle border token rather than going cool gray?

@mjabbink
Copy link

Agree on both. I don’t think the need is there for cool grey. Unless of course we switched all Grey to Cool Grey.

@joshblack joshblack added proposal: accepted This request has gone through triaging and we are accepting PR's against it. and removed status: waiting for author's response 💬 proposal: open This request has gone through triaging. We're determining whether we take this on or not. labels May 22, 2020
@aagonzales
Copy link
Member

aagonzales commented Jul 9, 2020

Status: ready for development.

Dev tasks:

  • add border to buttons in modal
  • add border to button groups in button component

Design tasks:

  • update modal images on website
  • update in modal kit symbols

@laurenmrice
Copy link
Member

Closing because this has been added 👍🏻

@fabpico
Copy link
Contributor

fabpico commented Apr 14, 2021

The official docs says this update is not yet made. Maybe someone can update the docs?

Although we haven’t made this update yet, we plan to add a 1px border between all fluid buttons that calls the $ui-03 token for subtle borders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: button proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: enhancement 💡
Projects
None yet
Development

No branches or pull requests

9 participants