Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DropdownSkeleton] Does not have associated label or accessible name #5613

Closed
zJag opened this issue Mar 12, 2020 · 0 comments · Fixed by #5619
Closed

[DropdownSkeleton] Does not have associated label or accessible name #5613

zJag opened this issue Mar 12, 2020 · 0 comments · Fixed by #5619

Comments

@zJag
Copy link

zJag commented Mar 12, 2020

Environment

Browser

Found in Chrome. But probably all browsers.

Automated testing tool and ruleset

DAP chrome extension

Detailed description

What version of the Carbon Design System are you using?

v10.10.1

What did you expect to happen?

When using a DropdownSkeleton DAP should not find accessibility violations.

What happened instead?

Two violations are found.

  • Form control element div is missing associated label.
  • An interactive element/widget does not have an accessible name.

Steps to reproduce the issue

  1. Step one - Render DropdownSkeleton component
  2. Step two - Inspect with DAP tool

CodeSandbox

Additional information

This looks like it's because the skeleton is given a role of button(link). If you look at the TextInputSkeleton, it does not have this "role" and does not have the same issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants