Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[danger button] add tertiary and ghost variants #5610

Closed
3 tasks done
laurenmrice opened this issue Mar 12, 2020 · 0 comments · Fixed by #7087
Closed
3 tasks done

[danger button] add tertiary and ghost variants #5610

laurenmrice opened this issue Mar 12, 2020 · 0 comments · Fixed by #7087
Assignees
@emyarod
Labels
component: button role: dev 🤖 type: enhancement 💡

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Mar 12, 2020 •
edited
Loading

Ref: #4945 accepted proposal for this need.

  • Add danger button options for tertiary and ghost.
  • Add a new token called danger-02. This will be used for tertiary and ghost danger button variants for enabled states.
  • We need to rename danger color token to danger-01.
White G10 G90 G100
Red 60 #da1e28 Red 60 #da1e28 Red 40 #fa8389 Red 50 #fa4d56

Specs:

Tertiary danger - light themes Copy.png

Ghost danger - light themes Copy.png
@aagonzales aagonzales mentioned this issue Mar 12, 2020
Closed
24 tasks
@emyarod emyarod self-assigned this Mar 12, 2020
@aagonzales aagonzales mentioned this issue Oct 19, 2020
Closed
@AlexanderLyon AlexanderLyon mentioned this issue Oct 20, 2020
Merged
@kodiakhq kodiakhq bot closed this as completed in #7087 Oct 27, 2020
This was referenced Oct 27, 2020
Closed
Closed
@emyarod emyarod mentioned this issue Jan 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emyarod emyarod

Labels
component: button role: dev 🤖 type: enhancement 💡
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(button): add tertiary and ghost danger buttons AlexanderLyon/carbon
2 participants
@emyarod @laurenmrice