Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StructuredListWrapper] - border prop does nothing #5590

Closed
2 tasks done
jnm2377 opened this issue Mar 10, 2020 · 0 comments · Fixed by #5592
Closed
2 tasks done

[StructuredListWrapper] - border prop does nothing #5590

jnm2377 opened this issue Mar 10, 2020 · 0 comments · Fixed by #5592
Assignees

Comments

@jnm2377
Copy link
Contributor

jnm2377 commented Mar 10, 2020

  • carbon-components
  • carbon-components-react

Detailed description

Describe in detail the issue you're having.

The StructuredListWrapper has a border prop which does nothing. This may have been a selector used in v9 that was removed in v10.

Screen Shot 2020-03-10 at 3 43 57 PM

You can see in the React component that this prop is supposed to apply a css selector:

    const classes = classNames(`${prefix}--structured-list`, className, {
      [`${prefix}--structured-list--border`]: border,
      [`${prefix}--structured-list--selection`]: selection,
    });

But, if you look at the styles for it, the selector doesn't exist.

It seems like this prop should be deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants