Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy between React link hover color and spec #5549

Closed
gillibrand opened this issue Mar 5, 2020 · 1 comment · Fixed by #5559
Closed

Discrepancy between React link hover color and spec #5549

gillibrand opened this issue Mar 5, 2020 · 1 comment · Fixed by #5559

Comments

@gillibrand
Copy link

According to https://www.carbondesignsystem.com/components/link/style/ there should be a hover color on links that's slightly darker than the at-rest color.

$hover-primary-text = #054ADA
$link-01 = #0f62fe

But none of the demos use it, e.g.,
https://www.carbondesignsystem.com/components/link/code/
or
https://react.carbondesignsystem.com/?path=/story/link--default

Is the spec wrong, or do the implementations need to change?

@laurenmrice
Copy link
Member

laurenmrice commented Mar 5, 2020

The style table doc is correct. The component itself needs to be updated.

For the link component, we should be using link-01 for enabled and hover-primary-text for hover. I will transfer this issue to the carbon repo.

@laurenmrice laurenmrice transferred this issue from carbon-design-system/carbon-website Mar 5, 2020
@joshblack joshblack mentioned this issue Mar 5, 2020
82 tasks
@emyarod emyarod self-assigned this Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants