Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NumberInput]: missing propTyles #5434

Closed
1 of 2 tasks
jnm2377 opened this issue Feb 25, 2020 · 2 comments
Closed
1 of 2 tasks

[NumberInput]: missing propTyles #5434

jnm2377 opened this issue Feb 25, 2020 · 2 comments
Labels
type: bug 🐛 type: docs 📖

Comments

@jnm2377
Copy link
Contributor

jnm2377 commented Feb 25, 2020

  • carbon-components
  • carbon-components-react

Detailed description

NumberInput is missing propTypes which is affecting the component demo on Carbon website.
You can see they all say node even though they're not node.

Screen Shot 2020-02-25 at 1 00 21 PM
Screen Shot 2020-02-25 at 1 00 04 PM
@tw15egan tw15egan self-assigned this Feb 26, 2020
@tw15egan
Copy link
Collaborator

Seems like this is an issue with ForwardRefs and PropTypes, see https://github.com/storybookjs/deprecated-addons/issues/7

Looks like we'll run into this issue with the following components:

  • InlineCheckbox
  • NumberInput
  • OverflowMenu
  • RadioButton
  • Tooltip

Might be fixed by implementing Storybook Docs to replace Storybook Info addon, so going to take some time looking into that. https://medium.com/storybookjs/storybook-docspage-e185bc3622bf

@tw15egan tw15egan mentioned this issue Feb 27, 2020
Merged
@joshblack joshblack mentioned this issue Mar 5, 2020
Closed
82 tasks
@tw15egan tw15egan removed their assignment Mar 6, 2020
@tw15egan
Copy link
Collaborator

Displaying correctly now 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug 🐛 type: docs 📖
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tw15egan @jnm2377