Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button size naming #5374

Closed
janhassel opened this issue Feb 18, 2020 · 3 comments · Fixed by #8459
Closed

Button size naming #5374

janhassel opened this issue Feb 18, 2020 · 3 comments · Fixed by #8459
Assignees
Labels
type: question ❓ version: 11 Issues pertaining to Carbon v11

Comments

@janhassel
Copy link
Member

Just a minor thing: Carbon has three button sizes (if you ignore the full-bleed version in the modals).
Where "Default" and "Small" are consistently used to describe the - well - default and small sizes 😀, the middle one is has three names:

In the Sketch kit it's "Medium"
image

In code it's "Field"
image

On the carbon website it's "Inline"
image

I can see that is hard to change the name in either the Sketch kit or code since it'd be a breaking change (although in code there could be a deprecation warning for a while).

@tw15egan tw15egan added the version: 11 Issues pertaining to Carbon v11 label Feb 18, 2020
@tw15egan
Copy link
Collaborator

tw15egan commented Feb 18, 2020

This should also map to the text input / select / dropdown sizing conventions, which in v11 will be small, medium / (default), and large

Related reading:

#5311
carbon-design-system/carbon-website#845 (comment)
#5076

@janhassel
Copy link
Member Author

Thanks for the links!

@tw15egan
Copy link
Collaborator

PR is up: #8459

@tw15egan tw15egan self-assigned this Apr 21, 2021
@kodiakhq kodiakhq bot closed this as completed in #8459 Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: question ❓ version: 11 Issues pertaining to Carbon v11
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants