Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify default component spacings #5367

Closed
30 tasks
janhassel opened this issue Feb 17, 2020 · 0 comments · Fixed by #9830
Closed
30 tasks

Clarify default component spacings #5367

janhassel opened this issue Feb 17, 2020 · 0 comments · Fixed by #9830
Labels
type: enhancement 💡 version: 11 Issues pertaining to Carbon v11
Milestone

Comments

@janhassel
Copy link
Member

Summary

Right now, most carbon components do not have any margin around them to allow the designer and developer to use them freely in their layout. Some components though (listed below) actually do have margins. Sometimes all around, sometimes only on specific sides.

These margins are not represented in the Sketch Kit, causing designers to build their layouts as if there were no spacings and developer struggling to implement the designs because they have to either (1) override the margins provided by carbon (and maybe shoot themselves in the foot in the long run) or (2) reject / adjust the designs (which can have serious issues on visual hierarchy and obviously makes it hard for the design team to review the implementation).

List of carbon components with default spacings

  • Fieldset (affects groups of checkboxes and radio buttons)
    • Bottom
  • File Uploader Drop Container (https://react.carbondesignsystem.com/?path=/story/fileuploader--fileuploaderdropcontainer)
    • Bottom
  • FormLabel
    • Bottom
  • InlineLoading
    • Top
    • Bottom
    • Left
    • The spacings are not defined as margin, but the size of the svg is set to 2rem despite only being 16px
      image
  • Loading
    • Top
    • Right
    • Bottom
    • Left
    • Spacings are also not defined as margin, same behaviour as with InlineLoading
  • Toast Notification
    • Top
    • Right
    • Bottom
  • Inline Notification
    • Top
    • Bottom
  • Structured list
    • Bottom
  • Toggle
    • Top
    • Bottom
  • Small Toggle
    • Top
    • Bottom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement 💡 version: 11 Issues pertaining to Carbon v11
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants