Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single buttons on modals should be half width #5346

Closed
1 of 2 tasks
kylembrake opened this issue Jan 27, 2020 · 4 comments · Fixed by #5502
Closed
1 of 2 tasks

Single buttons on modals should be half width #5346

kylembrake opened this issue Jan 27, 2020 · 4 comments · Fixed by #5502
Assignees

Comments

@kylembrake
Copy link

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

Describe in detail the issue you're having.

A single primary button inside a modal takes up the entire width of the modal. We've confirmed that the screenshot attached shows the correct styling of the button and the documentation on full-length buttons is incorrect.

Is this issue related to a specific component?

Modals and Buttons

What version of the Carbon Design System are you using?

"carbon-components": "^10.7.4",
"carbon-components-react": "^7.7.4",

Additional information

carbon-modal-bug

Our overriding styling:

.bx--modal-footer {
  justify-content: flex-end;
  button.bx--btn--primary {
    max-width: 50%;
  }
}
@asudoh
Copy link
Contributor

asudoh commented Jan 27, 2020

AFAIK it's actually a bug in website, it should take the full width actually.

@asudoh asudoh transferred this issue from carbon-design-system/carbon Jan 27, 2020
@mzuliani-ibm
Copy link

mzuliani-ibm commented Feb 13, 2020

The button description and @asudoh comment above contradicts the provided screen shot and “Acknowledgement Modal” guideline which says “span 50%“: https://www.carbondesignsystem.com/components/modal/usage#acknowledgment-modal

@emyarod emyarod transferred this issue from carbon-design-system/carbon-website Feb 13, 2020
@emyarod emyarod self-assigned this Feb 13, 2020
@laurenmrice
Copy link
Member

laurenmrice commented Feb 17, 2020

@asudoh It should not be full width if its one button in a modal, it should be 50%. The content needs to be updated on our website here.

@asudoh
Copy link
Contributor

asudoh commented Feb 17, 2020

@laurenmrice Yeah I heard of spec update somewhere recently and my apologies for my stale memory on the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants