-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot add 'aria-label' attribute to TableToolbarSearch.js component #5289
Comments
Related: #4665 @dakahn does an item with I'm not getting any DAP issues, @clarebyrne what errors are you seeing? |
@clarebyrne can you tell us a little about what you're trying to achieve or accomplish here and why? Right now the table toolbar search element has the label "Filter Table" seen here: |
Thanks @dakahn, i'm trying to put an aria-label within the role="search" div, not the role="searchbox" div. But aria-label or aria-labelledby aren't defined in div section of the component. This is the accessibility rule I was given: |
i'm not currently seeing a DAP error for our table toolbar -- who is reporting this error? |
@dakahn I'm getting the DAP warning on this page too: https://www.carbondesignsystem.com/components/search/code/ |
Hi @abbeyhrt will this fix be included in the upcoming v10.10.0 release? |
It will! We are currently planning on releasing 10.10 by the end of next week! |
What package(s) are you using?
carbon-components-react
Detailed description
Steps to reproduce the issue
See the role="search" region on Carbon storybook:
https://react.carbondesignsystem.com/?path=/story/datatable--with-toolbar
Screenshot shows the storybook with the relevant div highlighted:
Screenshot shows 'role="search"' region in TableToolbarSearch in carbon-design-system/carbon:
The text was updated successfully, but these errors were encountered: