Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover background color for Select component is wrong in G10 theme #5136

Closed
flannanl opened this issue Jan 22, 2020 · 2 comments · Fixed by #5150
Closed

Hover background color for Select component is wrong in G10 theme #5136

flannanl opened this issue Jan 22, 2020 · 2 comments · Fixed by #5150
Assignees

Comments

@flannanl
Copy link

flannanl commented Jan 22, 2020

I render the Select component like the following in my code:

<Select id="some-id"
    labelText="some label" light={true}>
      <SelectItem key="1" text="name1" value="value1"/>
      <SelectItem key="2" text="name2" value="value2"/>
      <SelectItem key="3" text="name3" value="value3"/>
</Select>

In G10 theme with light prop set to true, if I hover the Select component, the background color will become white and this is clashing with the white background color of my component.

Background color without hover:
image

Background color when hover:
image

The DOM of the Select component when hover
image

@asudoh
Copy link
Contributor

asudoh commented Jan 22, 2020

@carbon-design-system/design Any input? Thanks!

@laurenmrice
Copy link
Member

The hover color should be hover-ui token (Gray 10 hover #e5e5e5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants