Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sketch Library: IBM Icons (16px, 20px) showing wrong icon asset for 'filter' #4990

Closed
chrisconnors-ibm opened this issue Jan 9, 2020 · 9 comments

Comments

@chrisconnors-ibm
Copy link
Contributor

chrisconnors-ibm commented Jan 9, 2020

image

image

packages/icons/svg/16/filter.svg was moved to packages/icons/svg/16/settings--adjust.svg.

There is no packages/icons/svg/16/filter.svg anymore.

@chrisconnors-ibm
Copy link
Contributor Author

related: #4130
#4849

@chrisconnors-ibm
Copy link
Contributor Author

keepalive_bot this is still an issue:
image

@lukefirth
Copy link

Hey, is there any update as to where this falls on the roadmap/pipeline?

Its been plaguing us over in IoT where we've got a lot of filtering going on, and this issue is 2 months old without an assignee or estimated fix date, which makes me a little skittish 😄

@chrisconnors-ibm
Copy link
Contributor Author

it was dependent on other under the hood work in elements which just shipped - maybe @joshblack can update.

@joshblack
Copy link
Contributor

@chrisconnors-ibm one thing we should call out is that the library can be updated, it's just a manual process without the tooling in place.

Currently, I'm taking a look at our Sketch plugin again. Unfortunately, it seems like the rendering logic being used for the SVGs is rendering assets incorrectly. I will try and see how to resolve but in the meantime we can always hand update the design kit if there is anything pressing.

@laurenmrice
Copy link
Member

fixed 🎉! will be in next update of the sketch icon libraries

@chrisconnors-ibm
Copy link
Contributor Author

reopening because no one has updated the libraries, this is still asked about frequently
https://ibm-watsonhealth.slack.com/archives/C0M053VPT/p1604613965233300

@sstrubberg
Copy link
Member

hey @chrisconnors-ibm, we updated this in our Sketch kits. Let me know if it's still a thing.

@chrisconnors-ibm
Copy link
Contributor Author

hey @chrisconnors-ibm, we updated this in our Sketch kits. Let me know if it's still a thing.

@sstrubberg I don't even have a Sketch License anymore to check! 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

7 participants