Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumb visited link color issue #4920

Closed
nitishjain07 opened this issue Dec 19, 2019 · 4 comments · Fixed by #4976
Closed

Breadcrumb visited link color issue #4920

nitishjain07 opened this issue Dec 19, 2019 · 4 comments · Fixed by #4976

Comments

@nitishjain07
Copy link

Hi Team,

As per latest carbon design CSS, visited link has a different color(#8A3FFC) then default link color(#0F62FE). Because of this breadcrumb show links with different colors sometimes as you can see in the attached screenshot. As discussed in carbon-design-system slack channel (https://ibm-cognitive-engage.slack.com/archives/C0M053VPT/p1576687676025800?thread_ts=1576687465.025500&cid=C0M053VPT), raising a issue for this.

Screenshot 2019-12-18 at 10 08 51 PM

@asudoh
Copy link
Contributor

asudoh commented Dec 19, 2019

@carbon-design-system/design Any guidance on this...? Thanks!

@aagonzales
Copy link
Member

Yes, the breadcrumb should not have the visited state applied. It would actually be ideal if the link component could have the visited state be optional/configurable because it is common not to have the visited style while in a product.

@asudoh
Copy link
Contributor

asudoh commented Jan 6, 2020

Thanks @aagonzales! I think this can be done by changing style of .bx--breadcrumb-item .bx--link:visited.

@jendowns
Copy link
Contributor

jendowns commented Jan 8, 2020

I can help with this! PR coming up shortly 👍

EDIT: PR here #4976

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants