Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(tile) clickable tile should not have blue text #4850

Closed
laurenmrice opened this issue Dec 10, 2019 · 2 comments · Fixed by #5591
Closed

(tile) clickable tile should not have blue text #4850

laurenmrice opened this issue Dec 10, 2019 · 2 comments · Fixed by #5591
Assignees
@aledavila
Labels
component: tile severity: 4 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@laurenmrice
Copy link
Member

The text inside a clickable tile should not be a link, the tile itself should be the link. This is what the storybook currently is doing:
Screen Shot 2019-12-10 at 1.32.39 PM.png

The text should be text-01.
@abbeyhrt abbeyhrt added priority: medium severity: 4 https://ibm.biz/carbon-severity labels Dec 10, 2019
@joshblack
Copy link
Contributor

@laurenmrice I believe this is happening because the tile is built out as a link, if we want to change the color/underline what should we do to accommodate link requirements?

@laurenmrice
Copy link
Member Author

I would think we could just use a similar implementation as the carbon clickable tile we use on the website?

Ex:
Jan-13-2020 11-49-48

@joshblack joshblack mentioned this issue Mar 5, 2020
Closed
82 tasks
@aledavila aledavila self-assigned this Mar 6, 2020
@aledavila aledavila mentioned this issue Mar 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aledavila aledavila

Labels
component: tile severity: 4 https://ibm.biz/carbon-severity type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tile): add non link styling to clickable tile
5 participants
@mattrosno @joshblack @aledavila @abbeyhrt @laurenmrice