Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Shell: Missing "selected" state for header items #4800

Closed
1 of 2 tasks
stanislavgeorgiev opened this issue Nov 19, 2019 · 8 comments
Closed
1 of 2 tasks

UI Shell: Missing "selected" state for header items #4800

stanislavgeorgiev opened this issue Nov 19, 2019 · 8 comments

Comments

@stanislavgeorgiev
Copy link
Contributor

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

Describe in detail the issue you're having.

We want to use the selected state of the UI Shell header item which is already presented on the documentation website: https://www.carbondesignsystem.com/components/UI-shell-header/style#menu-item

image

I couldn't find how that selected state is getting triggered and there's seems to be no reference to it on neither website nor on the header style file.

Is this issue related to a specific component?

UI Shell

What did you expect to happen? What happened instead? What would you like to
see changed?

There should be documentation on how to enable that selected state.

What browser are you working in?

Chrome

What version of the Carbon Design System are you using?

10.7.3

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?

IBM ADDI

@asudoh
Copy link
Contributor

asudoh commented Nov 19, 2019

@carbon-design-system/design Do we define such state...? Thanks!

@laurenmrice
Copy link
Member

laurenmrice commented Nov 19, 2019

We should have a selected state mentioned above. I can't seem to trigger it in react for the links in the header.

@asudoh
Copy link
Contributor

asudoh commented Nov 19, 2019

Thanks @laurenmrice! I now see the UI shell in the website is just a mockup, instead of a non-interactive demo.

@asudoh asudoh transferred this issue from carbon-design-system/carbon Nov 19, 2019
@stanislavgeorgiev
Copy link
Contributor Author

@asudoh Should I move this issue to the carbon-design-system/carbon repo?

@asudoh
Copy link
Contributor

asudoh commented Nov 29, 2019

@stanislavgeorgiev I see the website needs to be changed to use the live demo instead of a mockup, and thus moved this issue from http://github.com/carbon-design-system/carbon to here, but don't hesitate to speak up if you see otherwise - Thanks!

@stanislavgeorgiev
Copy link
Contributor Author

ok, I got what happened now. This issue is asking to have a selected class for the header items not to update the website to use live demo instead of a mock up thus I'd rather keep it in the Carbon repo where it was originally filed if that's ok with you.

@asudoh asudoh transferred this issue from carbon-design-system/carbon-website Nov 29, 2019
@asudoh
Copy link
Contributor

asudoh commented Nov 29, 2019

I see, thank you @stanislavgeorgiev for clarifying!

@asudoh
Copy link
Contributor

asudoh commented Apr 9, 2020

Addressed by: #5504

@asudoh asudoh closed this as completed Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants