Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Snippet]: copy button style regression in latest unpublished code #4772

Closed
2 tasks done
jendowns opened this issue Nov 25, 2019 · 1 comment · Fixed by #4773
Closed
2 tasks done

[Code Snippet]: copy button style regression in latest unpublished code #4772

jendowns opened this issue Nov 25, 2019 · 1 comment · Fixed by #4773

Comments

@jendowns
Copy link
Contributor

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

The CopyButton inside the CodeSnippet is positioned strangely in the latest, unpublished code on the master branch:

Screen Shot 2019-11-25 at 1 57 58 PM
Screen Shot 2019-11-25 at 1 58 07 PM

Unfortunately you can't view this regression directly in any main deployment because those deployments, like the React storybook environment, are only updated after a release.

So here are two options to see the regressions:

@jendowns
Copy link
Contributor Author

Appears to be related to a class name being left out. I can propose a fix shortly 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant