Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] Refactor DatePicker to be more accessible to screen reader and keyboard users #4763

Closed
dakahn opened this issue Nov 22, 2019 · 3 comments
Labels
role: dev 🤖 severity: 1 https://ibm.biz/carbon-severity type: a11y ♿

Comments

@dakahn
Copy link
Contributor

dakahn commented Nov 22, 2019

The current implementation of our DatePicker has serious usability and keyboard accessibility issues. We've been relying on a third party library for our calendar drop down functionality and a refactor involving an in-house solution could greatly simplify component API, debugging, and accessibility bug fixes moving forward.

As for guidance -- there are browser date picker defaults that are quite accessible and building on top or these seems like the smart move. As an alternative the jQuery UI Datepicker has historically been highly regarded from a keyboard accessibility/screen reader standpoint.

Re-evaluating our Datepicker's calendar dropdown functionality has value as well. I suggest we take a cue from the Gov.uk design system and rethink this interaction altogether.

After talking about this last year (circa October?) we chose to shore up any existing issues and move forward with FlatPicker as our calendar libarary

Update 2/10/20

ref #5310

Given this latest crop of accessibility issues for keyboard, JAWS, and VO -- I think there's value in returning to the discussion of alternatives here if the cost makes sense. For example Airbnb's React-Dates seems very thoughtfully implemented in terms of screen reader a11y and reads quite well in JAWS and VoiceOver

@carbon-design-system/developers pinging the team for thoughts and input

@dakahn dakahn added type: a11y ♿ severity: 1 https://ibm.biz/carbon-severity priority: high labels Nov 22, 2019
@dakahn dakahn added this to the ♿Carbon WCAG Compliance♿ milestone Nov 22, 2019
@dakahn dakahn changed the title Refactor DatePicker in to be more usable and keyboard accessible Refactor DatePicker to be more usable and keyboard accessible Nov 22, 2019
@joshblack
Copy link
Contributor

@dakahn for rethinking the interaction, would this be something where we want to include design?

@dakahn
Copy link
Contributor Author

dakahn commented Feb 10, 2020

reopening as per request by @snidersd

We have a new batch of keyboard and screen reader issues with our DatePicker w/Calendar :hurtrealbad:

@dakahn dakahn reopened this Feb 10, 2020
@dakahn dakahn assigned dakahn and unassigned dakahn Feb 10, 2020
@dakahn dakahn changed the title Refactor DatePicker to be more usable and keyboard accessible [PROPOSAL] Refactor DatePicker to be more accessible to screen reader and keyboard users Feb 10, 2020
@dakahn
Copy link
Contributor Author

dakahn commented Mar 5, 2020

Closing this up again. Conversation was DOA and it looks like we're just going to continue with flatpickr for the time being

@dakahn dakahn closed this as completed Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: dev 🤖 severity: 1 https://ibm.biz/carbon-severity type: a11y ♿
Projects
None yet
Development

No branches or pull requests

3 participants