Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy button should inherit tooltip component styles for feedback message #4711

Closed
2 tasks done
emyarod opened this issue Nov 18, 2019 · 1 comment · Fixed by #4715
Closed
2 tasks done

Copy button should inherit tooltip component styles for feedback message #4711

emyarod opened this issue Nov 18, 2019 · 1 comment · Fixed by #4715
Assignees
@emyarod
Labels
type: bug 🐛

Comments

@emyarod
Copy link
Member

emyarod commented Nov 18, 2019

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

Currently the tooltip that appears for the feedback message does not have the correct spacing and the text is very close to the container.

Example:
Screen Shot 2019-11-07 at 11.57.13 AM.png

We need to be using the tooltip component in these scenarios for code snippet.

Since the code snippet directly consumes the copy button component, the changes should be in the copy button as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emyarod emyarod

Labels
type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(CopyButton): use tooltip styles for feedback and add animation emyarod/carbon
1 participant
@emyarod