Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

side-nav does not use the theme and is hardcoded to white #4471

Closed
treyhuffine opened this issue Oct 27, 2019 · 1 comment
Closed

side-nav does not use the theme and is hardcoded to white #4471

treyhuffine opened this issue Oct 27, 2019 · 1 comment

Comments

@treyhuffine
Copy link

I am trying to use Carbon in dark mode, and the side nav is hardcoded to white. Is this intended or should I send a PR to use background of the chosen theme?

https://github.com/carbon-design-system/carbon/blob/master/packages/components/src/components/ui-shell/_theme.scss#L156

Applying the dark theme using the following feels like an unintentional bug for the UI.

@import '@carbon/themes/scss/themes';
$carbon--theme: $carbon--theme--g100;
@include carbon--theme();

@import 'carbon-components/scss/globals/scss/styles.scss';

Screen Shot 2019-10-27 at 5 07 59 PM

@joshblack
Copy link
Contributor

Hi there! 👋 It's currently not possible to theme the UI Shell, however we have an open issue to revisit our usage of private tokens here to allow for theming: #4839

I'm going to close this for now and point folks over to that feature issue for theming UI Shell. Hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants