Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVT 3 - React MultiSelect multiple navigation issues while using VO #4197

Closed
snidersd opened this issue Oct 3, 2019 · 2 comments
Closed
Assignees
Labels
package: react carbon-components-react severity: 1 https://ibm.biz/carbon-severity type: a11y ♿ type: bug 🐛

Comments

@snidersd
Copy link

snidersd commented Oct 3, 2019

Environment

macOS 10.14.6
Chrome Version 77.0.3865.90
VoiceOver

Description

This issue applies to both the default MultiSelect and the MultiSelect w/initial selected items:

  1. With VO active tab to the MultiSelect
  2. VO does not announce the Multiselect label
    Expected Result: The label should be announced
  3. Use the enter key to open the menu, but the menu fails to open
    Expected Result: The enter key should open the menu
  4. Use the space key to open the menu, works as expected.
  5. Arrow to a selection and press Space bar to check the box, VO announces the option text but does allow the user to make a selection.
    Expected Result: User should be able to check 1 or more checkboxes.
@snidersd snidersd added this to the MultiSelect - A11y Project Team milestone Oct 3, 2019
@dakahn dakahn added the severity: 1 https://ibm.biz/carbon-severity label Oct 15, 2019
@carmacleod
Copy link
Contributor

These checkboxes can currently be checked with the enter key... however, the expected behavior is for them to be checked with the space key.

Note that I don't think you want to keep allowing the Enter key to check/uncheck the checkboxes, because what if the control is in a dialog that has a default button that is activated on Enter?

So I think the check/uncheck behavior has to be on space key only, which is how the regular Carbon checkboxes operate already (i.e. Space only, not Enter). Thanks!

Storybook link for multiselect: http://react.carbondesignsystem.com/?path=/story/multiselect--default
Storybook link for regular checkboxes: http://react.carbondesignsystem.com/?path=/story/checkbox--checked

@dakahn dakahn modified the milestones: MultiSelect - A11y Project Team, Carbon WCAG Compliance Nov 21, 2019
@mattrosno mattrosno removed this from the ♿Carbon WCAG Compliance♿ milestone Dec 13, 2019
@abbeyhrt abbeyhrt self-assigned this Feb 4, 2020
@joshblack joshblack mentioned this issue Mar 4, 2020
82 tasks
@joshblack joshblack mentioned this issue Mar 27, 2020
79 tasks
@dakahn
Copy link
Contributor

dakahn commented May 8, 2020

closed by #5373

@dakahn dakahn closed this as completed May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react carbon-components-react severity: 1 https://ibm.biz/carbon-severity type: a11y ♿ type: bug 🐛
Projects
None yet
Development

No branches or pull requests

5 participants