-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text in various components slightly shifted in iOS Safari #3922
Comments
cc @vpicone have you all run into anything like this on the Plex side? |
Still an issue when viewing on iPhone XS Max |
After some lengthy debugging I think I've finally pinned down the cause of this. These alignment issues are not present in the storybook, they're only present on the component demos within the carbondesignsystem.com website. The website uses the IBM Plex Variable Font (VF), whereas the storybook (and the overall default font family in the root styles) use the non-variable IBM Plex family. If I override the font family on the website you can see the vertical alignment movement: variable.font.alignment.movI've been unable to pin down if this is a browser issue, a problem with the variable font, or a problem with our usage of the variable font. It's worth noting that we don't see these alignment problems on the website in Chrome, which leads me to suspect it's an iOS webkit/safari bug. |
I do see a small shift in chrome as well actually small.shift.in.chrome.mov |
Opened an issue on the plex repo for this, IBM/plex#377 |
With Plex v6.3.0 now out, this issue should be fixed in the variable font. We need to update
|
this issue appears to be resolved |
What package(s) are you using?
carbon-components
carbon-components-react
Detailed description
The text of a few components is slightly off in iOS Safari. The shift in positioning is around 1-2px which doesn't prevent the components from working but they make the overall design look less robust as it is definitely noticeable.
Following components are affected:
Here is a brief showcase of the problem. In all three examples the text is positioned too high. It should be aligned with its input element or the surrounding box.
Desktop in background: Safari 12.1.2 on Mac OS Mojave 10.14.6
Smartphone in foreground: Safari on iPhone 8 running iOS 12.4
All screenshots were taken from the component pages on the Carbon Design website.
I'm not using Carbon at the moment but I'm considering using it for a new project. Many users will be on mobile Safari, so it's important that the UI looks good there.
Steps to reproduce the issue
The text was updated successfully, but these errors were encountered: