Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiSelect - DAP violations #3776

Closed
marcyb1966 opened this issue Aug 21, 2019 · 1 comment
Closed

MultiSelect - DAP violations #3776

marcyb1966 opened this issue Aug 21, 2019 · 1 comment

Comments

@marcyb1966
Copy link

DAP violations in MultiSelect component

Environment

Operating system
Mac

Browser
Chrome

Automated testing tool and ruleset
N/A

Assistive technology used to verify
DAP via the Chrome plugin

Detailed description

When running DAP against my UI, I get the following violations concerning the MultiSelect component:

  1. Use grouping roles or elements to identify related form controls (one per item in Multiselect)
  2. An interactive element/widget must have an accessible name

Related to #1, I also get the following potential violation
Elements with a role attribute must have required child elements for the role

For item #1, it doesn't seem to like that the role of "listbox" on the "select_XXX_menu" div (which contains all the checkbox items in the MultiSelect). When I change role to "group", the violations (including #2) as well as the potential violation I mentioned go away. This is the changed div:
image

For #2, I was able to make it go away by adding an aria-label

What version of the Carbon Design System are you using?
"carbon-components": "10.4.1",
"carbon-components-react": "7.4.1",

What did you expect to happen?
No DAP violations with MultiSelect component

What happened instead?
Got DAP errors as described above.

What WCAG 2.1 checkpoint does the issue violate?
UIs must not have an DAP violations

Steps to reproduce the issue

  1. Render a UI that contains the MultiSelect component. Open the dropdown (must be open to see issues).
  2. Run DAP
  3. You will get violations mentioned in description.

Please create a reduced test case in CodeSandbox

https://codesandbox.io/s/codesandbox-z7bjp

Additional information

  • Screenshots or code
  • Notes
@dakahn dakahn added this to the MultiSelect - A11y Project Team milestone Sep 30, 2019
@dakahn
Copy link
Contributor

dakahn commented Sep 30, 2019

tracking this in #4008 👍

@dakahn dakahn closed this as completed Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants