Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behavior in keyboard navigation in DropdownV2 #2600

Closed
JohnWColby opened this issue Sep 21, 2018 · 8 comments
Closed

Unexpected behavior in keyboard navigation in DropdownV2 #2600

JohnWColby opened this issue Sep 21, 2018 · 8 comments
Labels
package: react carbon-components-react role: dev 🤖 severity: 1 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@JohnWColby
Copy link
Contributor

Detailed description

Describe in detail the issue you're having.

When using keyboard navigation, the DropdownV2 component gets focus twice. It also does not open the menu on an enter press.

Is this issue related to a specific component?

Yes, DropdownV2.

What browser are you working in?

Chrome

What version of the Carbon Design System are you using?

6.28.3

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

Watson Compare & Comply Tooling UI, no extremely pressing deadline

Steps to reproduce the issue

  1. Navigate to the DropdownV2 > default Storybook story. (http://react.carbondesignsystem.com/?knob-The%20title%20%28title%29=Section%201%20title&knob-Dropdown%20type%20%28type%29=default&knob-Label%20%28label%29=Label&selectedKind=DropdownV2&selectedStory=default&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel)
  2. Press "tab" key. Note that element div.bx--dropdown.bx--list-box receives focus. Note that pressing enter or using the arrow keys seem to do nothing. (Not expected, pressing enter or the down key should open the menu.)
  3. Press "tab" key again. Note that element div.bx--list-box__field receives focus. (Not expected, as this essentially focuses on the same button.) Note that pressing enter seems to do nothing. (Not expected, pressing enter should open the menu.) Note that pressing the down key does open the menu, and that further navigation from this point is straightforward / intuitive. (This is as expected.)
@joshblack
Copy link
Contributor

Thanks for making this @ColbyJohnIBM! This definitely seems like a regression, as enter or spacebar should definitely open up the control. Will need to dive in further 👍

@JohnWColby
Copy link
Contributor Author

This issue is becoming more pressing for us as we're trying to make our application more accessible. Any thoughts on when this might be worked on?

@lpatino10
Copy link

Seeing the same issues and also looking forward to a fix.

@joshblack
Copy link
Contributor

@lpatino10 thanks for chiming in! Just wanted to say that the fastest way to see a fix is to create a Pull Request for it! Always looking for contributions 😄

@stale
Copy link

stale bot commented May 1, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. Thanks for your contributions.

@carbon-bot carbon-bot transferred this issue from carbon-design-system/carbon-components-react May 9, 2019
@carbon-bot carbon-bot added package: react carbon-components-react severity: 2 https://ibm.biz/carbon-severity type: bug 🐛 role: dev 🤖 wontfix labels May 9, 2019
@carbon-bot
Copy link
Contributor

Hi there! 👋 If you're wondering why this issue was moved, we're currently updating our repo structure so that every package is found in the same project.

This should not have any impact for you, but we wanted to give you a heads up in case you were wondering what is going on. If you have any questions, feel free to reach out to us on Slack or contact us at: [email protected]. Thanks!

@dakahn
Copy link
Contributor

dakahn commented May 14, 2019

Just chiming in here. Doing an AVT2 test and dropdown v10 does not open on enter in the latest Firefox on Windows :hurtrealbad:

I'll escalate the severity and priority 👍

@dakahn dakahn added severity: 1 https://ibm.biz/carbon-severity priority: high and removed severity: 2 https://ibm.biz/carbon-severity labels May 14, 2019
@joshblack joshblack removed the wontfix label Sep 25, 2019
@joshblack
Copy link
Contributor

@dakahn I believe this should be resolved now with @aledavila latest fix! Or, at the very least, things like enter and double VO focus seem to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react carbon-components-react role: dev 🤖 severity: 1 https://ibm.biz/carbon-severity type: bug 🐛
Projects
None yet
Development

No branches or pull requests

6 participants