Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some experimental components show as <Unknown> in addon-info story source #2566

Closed
vpicone opened this issue Nov 14, 2018 · 6 comments
Closed
Labels
package: react carbon-components-react severity: 2 https://ibm.biz/carbon-severity status: inactive Will close if there's no further activity within a given time

Comments

@vpicone
Copy link
Contributor

vpicone commented Nov 14, 2018

Detailed description

When wrapped with React.forwardRef, some components show up as <Unknown> in addon-info's story source. I've outlined some potential solutions in a storybook issue: storybookjs/storybook#4787. Ideally, we wouldn't need to change anything about the components and storybook would just more intelligently handle HoCs, especially those provided by react. That aside, one of those solutions might be preferable if they don't do anything and the experimental features need to get shipped.

HeaderMenuItem

@vpicone
Copy link
Contributor Author

vpicone commented Nov 15, 2018

Tangently related, there’s some neat standard hooks coming out around refs: https://reactjs.org/docs/hooks-reference.html#useref

@asudoh
Copy link
Contributor

asudoh commented Nov 16, 2018

Thanks @vpicone for creating an issue here and in the Storybook! Let's see how Storybook resolves the issue. How Storybook would work with hooks is an interesting topic, too.

@stale
Copy link

stale bot commented May 1, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. Thanks for your contributions.

@carbon-bot carbon-bot transferred this issue from carbon-design-system/carbon-components-react May 9, 2019
@carbon-bot carbon-bot added package: react carbon-components-react wontfix labels May 9, 2019
@carbon-bot
Copy link
Contributor

Hi there! 👋 If you're wondering why this issue was moved, we're currently updating our repo structure so that every package is found in the same project.

This should not have any impact for you, but we wanted to give you a heads up in case you were wondering what is going on. If you have any questions, feel free to reach out to us on Slack or contact us at: [email protected]. Thanks!

@dakahn dakahn added Storybook severity: 2 https://ibm.biz/carbon-severity and removed wontfix labels May 14, 2019
@stale
Copy link

stale bot commented Jun 13, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Jun 13, 2019
@stale
Copy link

stale bot commented Jun 16, 2019

As there's been no activity since this issue was marked as stale, we are auto-closing it.

@stale stale bot closed this as completed Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react carbon-components-react severity: 2 https://ibm.biz/carbon-severity status: inactive Will close if there's no further activity within a given time
Projects
None yet
Development

No branches or pull requests

4 participants