Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Table: the $data-table-zebra-color token is a hard-coded un-themed hex value #2351

Closed
jendowns opened this issue Apr 25, 2019 · 0 comments · Fixed by #2352
Closed

Data Table: the $data-table-zebra-color token is a hard-coded un-themed hex value #2351

jendowns opened this issue Apr 25, 2019 · 0 comments · Fixed by #2352

Comments

@jendowns
Copy link
Contributor

Detailed description

The $data-table-zebra-color is a theme token that applies to all odd-numbered rows in a zebra DataTable, but the token is actually a hard-coded hex value and therefore it breaks for all dark themes (i.e., appears as #FCFCFC and is unreadable).

See: https://github.com/IBM/carbon-components/blob/master/src/globals/scss/_theme-tokens.scss#L203

 $data-table-zebra-color: #fcfcfc !default !global;

Ideally this token should instead use a role-based token from @carbon/themes so that it can work for dark UI themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant