Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve NumberInput test coverage of allowEmpty #16207

Closed
tay1orjones opened this issue Apr 15, 2024 · 0 comments · Fixed by #16254
Closed

Improve NumberInput test coverage of allowEmpty #16207

tay1orjones opened this issue Apr 15, 2024 · 0 comments · Fixed by #16254
Assignees
@2nikhiltom
Labels
component: number-input role: dev 🤖 type: infrastructure 🤖 Issues relating to devops, tech debt, etc.

Comments

@tay1orjones
Copy link
Member

We recently had some bugs come through on NumberInput specifically related to the allowEmpty prop. The test coverage for this component needs to be improved so that the flows outlined in the bugs are covered in tests. These can reside in packages/react/src/components/NumberInput/__tests__/NumberInput-test.js
@tay1orjones tay1orjones moved this to ⏱ Backlog in Design System Apr 15, 2024
@tay1orjones tay1orjones added the type: infrastructure 🤖 Issues relating to devops, tech debt, etc. label Apr 15, 2024
@tay1orjones tay1orjones mentioned this issue Apr 15, 2024
Merged
@tay1orjones tay1orjones added this to the 2024 Q2 milestone Apr 15, 2024
@2nikhiltom 2nikhiltom mentioned this issue Apr 24, 2024
Merged
@2nikhiltom 2nikhiltom moved this from ⏱ Backlog to 🚦 In Review in Design System Apr 24, 2024
@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@2nikhiltom 2nikhiltom

Labels
component: number-input role: dev 🤖 type: infrastructure 🤖 Issues relating to devops, tech debt, etc.
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(16207): adds NumberInput test coverage of allowEmpty 2nikhiltom/carbon
2 participants
@tay1orjones @2nikhiltom