Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: config prefix hardcoded to 'cds' in _default-type.scss for anchor color property #14835

Closed
2 tasks done
JakeMetz8 opened this issue Oct 10, 2023 · 0 comments · Fixed by #14852
Closed
2 tasks done

Comments

@JakeMetz8
Copy link

Package

@carbon/type

Browser

No response

Package version

11.33.0

React version

No response

Description

Lines 43 set the color property of anchor. However, they it's hardcoded with the cds prefix rather than dynamically using the prefix from config. This breaks when a user of your system sets a different prefix.

    43: color: var(--cds-link-primary);

suggested:

    43: color: var(--#{config.$prefix}-link-primary);

Reproduction/example

https://github.com/carbon-design-system/carbon/blob/release/v11.27.0/packages/type/scss/_default-type.scss

Steps to reproduce

Set the prefix to something other than cds. Check default type styles to see if color of link is broken

Suggested Severity

None

Application/PAL

No response

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant