Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dividers in Components πŸ–οΈ #13682

Closed
9 tasks done
thyhmdo opened this issue Apr 27, 2023 · 2 comments
Closed
9 tasks done

Dividers in Components πŸ–οΈ #13682

thyhmdo opened this issue Apr 27, 2023 · 2 comments

Comments

@thyhmdo
Copy link
Member

thyhmdo commented Apr 27, 2023

Dividers in components

Overview

There is currently an inconsistency of the presence or lack of dividers that we provide in our components, specifically in instances where there are multiple icons inside of a component that live next to each other.

We need to decide when and how we use dividers like this across our components to create better consistency. We also need to consider how the AI slug is being used in these situations when AI is present. (Ref: Carbon for AI Figma file)

Here are a couple of examples of where we do and don't use them:


Example: Number input

  • Enabled state: The number input component dividers help separate the - / + controls visually.
  • Hover state: Unlike most of our other form components, the number input - / + controls additionally get a color background change on hover because they are treated as icon buttons instead of just icons.
  • Error state: There is an addition of the error icon in the field, and another divider appears next to the - control.
number input

Example: Combobox

  • Selected state: The combobox component, when an option is selected, the close and chevron icons only get a mouse cursor change and have no dividers between them
  • Hover state: The close and chevron icons only get a cursor hover change and no background color change because they are icons, not icon buttons. They also don't have a divider between them.
  • Error state: There is an addition of the error icon in the field, and there is no divider.
combobox

Default component tasks

  1. role: design ✏️ type: docs πŸ“–
    alina-jacob
  2. role: design ✏️ type: enhancement πŸ’‘
    alina-jacob
  3. kit: figma role: design ✏️ type: enhancement πŸ’‘ version: 11
    alina-jacob
  4. role: design ✏️ type: docs πŸ“–
    alina-jacob
  5. role: design ✏️ type: docs πŸ“–
    alina-jacob
  6. component: combobox component: filterable-multiselect component: search role: dev πŸ€– type: enhancement πŸ’‘
    guidari

AI component tasks

  1. area: AI role: design ✏️ type: enhancement πŸ’‘
    alina-jacob
  2. area: AI component: combobox component: dropdown component: filterable-multiselect component: form component: modal component: multiselect component: number-input component: select role: dev πŸ€– version: 11
    2nikhiltom riddhybansal
    tw15egan
@tay1orjones
Copy link
Member

tay1orjones commented May 10, 2023

Things to answer in refinement:

  • Do we want this?
    • How did the discrepancy between figma and storybook happen? Is this part of the original spec, or an updated one?
  • How many components would this impact?

@sstrubberg
Copy link
Member

Audit the inputs. Where are the dividers? What is the original spec?

@sstrubberg sstrubberg changed the title [Dropdown] Consider a divider between elements Audit components for dividers πŸ–οΈ May 15, 2023
@sstrubberg sstrubberg added this to the 2023 Q3 milestone May 15, 2023
@sstrubberg sstrubberg moved this from Triage to Later in Roadmap Jun 12, 2023
@laurenmrice laurenmrice changed the title Audit components for dividers πŸ–οΈ Dividers in components πŸ–οΈ Jun 27, 2023
@laurenmrice laurenmrice added the planning: umbrella Umbrella issues, surfaced in Projects views label Jun 27, 2023
@sstrubberg sstrubberg modified the milestones: 2023 Q3, 2023 Q4 Jul 31, 2023
@tay1orjones tay1orjones moved this from Later to Now in Roadmap Oct 2, 2023
@sstrubberg sstrubberg modified the milestones: 2023 Q4, 2024 Q1 Nov 8, 2023
@laurenmrice laurenmrice moved this from πŸͺ† Needs Refined to ⏱ Backlog in Design System Nov 15, 2023
@laurenmrice laurenmrice moved this from ⏱ Backlog to πŸͺ† Needs Refined in Design System Nov 15, 2023
@sstrubberg sstrubberg removed this from the 2024 Q1 milestone Nov 28, 2023
@alina-jacob-ibm alina-jacob-ibm self-assigned this Jan 4, 2024
@alina-jacob-ibm alina-jacob-ibm changed the title Dividers in components πŸ–οΈ Dividers in Components πŸ–οΈ Jan 4, 2024
@sstrubberg sstrubberg added this to the 2024 Q1 milestone Jan 6, 2024
@sstrubberg sstrubberg moved this from πŸͺ† Needs Refined to ⏱ Backlog in Design System Mar 6, 2024
@alina-jacob alina-jacob moved this from ⏱ Backlog to πŸ— In Progress in Design System Mar 20, 2024
@alina-jacob alina-jacob removed the status in Design System Mar 20, 2024
@alina-jacob alina-jacob moved this to πŸ— In Progress in Design System Mar 20, 2024
@laurenmrice laurenmrice modified the milestones: 2024 Q1, 2024 Q2 Mar 27, 2024
@alina-jacob alina-jacob moved this from πŸ— In Progress to βœ… Done in Design System May 30, 2024
@alina-jacob alina-jacob closed this as completed by moving to βœ… Done in Design System May 30, 2024
@github-project-automation github-project-automation bot moved this from Now to Completed in Roadmap May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

No branches or pull requests

6 participants