Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fluid inputs: FluidDropdown #12107

Closed
7 of 12 tasks
Tracked by #5416
, #559
...
tay1orjones opened this issue Sep 16, 2022 · 0 comments · Fixed by #12128
Closed
7 of 12 tasks
Tracked by #5416
, #559
...

Fluid inputs: FluidDropdown #12107

tay1orjones opened this issue Sep 16, 2022 · 0 comments · Fixed by #12128
Assignees
@tw15egan
Labels
package: @carbon/react @carbon/react role: design ✏️ role: dev 🤖 type: enhancement 💡
Milestone
2022 Q4

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Sep 16, 2022 •
edited by aagonzales
Loading

This issue is for the primary implementation and design of the FluidDropdown component.

Checklist

  • Fluid inputs: Dropdown docs carbon-website#3174
    • Update "style" and "usage" tabs of component page to include Fluid variant
  • [Figma] Add "Fluid-input: Dropdown" carbon-design-kit#575
  • Fluid inputs: Add FluidDropdown experimental implementation
    • Place implementation within a new component, FluidComponentName
    • Add VRT tests via storybook story e2e setup
    • Add unit tests (likely simple, eg. "does the classname get added")
    • Add storybook example
    • Add it to the FluidForm story
    • Ensure styles are properly scoped to their own file
    • Add component: FluidDropdown label to repo for triaging issues
  • Fluid inputs: FluidDropdownSkeleton

Spec

Sketch file | Figma file

Dropdown - White2x
@tay1orjones tay1orjones mentioned this issue Sep 16, 2022
Closed
@tay1orjones tay1orjones moved this to 🪆 Needs Refined in Design System Sep 16, 2022
@tay1orjones tay1orjones added this to the 2022 Q3 milestone Sep 20, 2022
@tay1orjones tay1orjones moved this from 🪆 Needs Refined to 🏗 In Progress in Design System Sep 20, 2022
@tay1orjones tay1orjones changed the title Fluid inputs: Dropdown Fluid inputs: FluidDropdown Sep 20, 2022
@tw15egan tw15egan mentioned this issue Sep 20, 2022
Merged
@kodiakhq kodiakhq bot closed this as completed in #12128 Oct 6, 2022
Repository owner moved this from 🏗 In Progress to ✅ Done in Design System Oct 6, 2022
@tay1orjones tay1orjones modified the milestones: 2022 Q3, 2022 Q4 Nov 2, 2022
This was referenced Dec 1, 2022
Closed
Closed
@aagonzales aagonzales mentioned this issue Jan 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tw15egan tw15egan

Labels
package: @carbon/react @carbon/react role: design ✏️ role: dev 🤖 type: enhancement 💡
Projects
Design System
Archived in project
Milestone
2022 Q4
Development

Successfully merging a pull request may close this issue.

feat(FluidDropdown): implement FluidDropdown tw15egan/carbon
2 participants
@tay1orjones @tw15egan