Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y]: File uploader item icon is tabbable & has incorrect role. #12101

Closed
2 tasks done
Akshat55 opened this issue Sep 15, 2022 · 2 comments · Fixed by #12105
Closed
2 tasks done

[a11y]: File uploader item icon is tabbable & has incorrect role. #12101

Akshat55 opened this issue Sep 15, 2022 · 2 comments · Fixed by #12105

Comments

@Akshat55
Copy link
Contributor

Akshat55 commented Sep 15, 2022

Package

@carbon/react

Browser

Chrome, Firefox

Operating System

Windows, MacOS

Package version

1.12.0

React version

17/18

Automated testing tool and ruleset

IBM equal access accessibility checker - Latest Deployment

Assistive technology

No response

Description

The tabbable element's role 'img, graphics-document' is not a widget role. The checkmark--filled icon is tabbable (tabindex="0") and the role assigned to the svg is img (role="img").

This accessibility issue can be observed via storybook. Set status to complete & open the canvas in a new tab (With only File uploader item story) & run IBM equal accessibility checker.

Permalink to icon in code.

image

Have ran the checker on firefox & chrome only.

WCAG 2.1 Violation

No response

Reproduction/example

https://react.carbondesignsystem.com/iframe.html?args=status:complete&id=components-fileuploader--file-uploader-item&viewMode=story

Steps to reproduce

  • Set File uploader item status to complete
  • Run checker

Code of Conduct

@Akshat55
Copy link
Contributor Author

I'm not even sure if the icon should be tabbable 🤔

@tw15egan
Copy link
Collaborator

It should probably only be tabbable if the status is set to edit, since that is the x button to delete the file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants