Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

components/ContentSwitcher/next/ContentSwitcher.stories.js #11564

Closed
1 of 6 tasks
Tracked by #10751
aledavila opened this issue Jun 6, 2022 · 0 comments · Fixed by #11747
Closed
1 of 6 tasks
Tracked by #10751

components/ContentSwitcher/next/ContentSwitcher.stories.js #11564

aledavila opened this issue Jun 6, 2022 · 0 comments · Fixed by #11747
Assignees

Comments

@aledavila
Copy link
Contributor

aledavila commented Jun 6, 2022

Every component in the storybook sidebar should have a Playground story, those stories should have operable controls.

High level checklist for each component:

  • Move .stories.js file out of next folder, or create .stories.js file and copy contents of *-story.js file over.
  • Remove deprecated knobs package and usage.
  • Ensure there is a playground story
  • Add argtypes to playground story
  • Pass ...args to playground story, spread them on the applicable component(s)
  • Remove deprecated props from being visible in controls of storybook #11249

FAQ:

  • What if there's no playground story but other stories have controls enabled on them?
    • Create a playground story and make to add the argType to playground
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant