-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Icon color in ghost button is filled in wrong color when high contrast mode + dark theme #11557
Comments
Just an FYI MacOS "Increase Contrast" isn't fully supported by browsers, thus the high contrast modes don't always apply properly. Do you still see this issue when using Windows High Contrast mode? In V11, there is an |
Updating to the latest versions of V10 seems to resolve this issue though: https://codesandbox.io/s/tearsheet-example-forked-ngc0l5?file=/src/Theme/ThemeDropdown.js |
Closing as I'm unable to reproduce on the latest version of V10. The icon is showing as visible in MacOS "Increase Contrast" mode as well as Windows HCM in both light and dark themes. |
The latest V10 worked for me as well. Thank you. |
Package
carbon-components, carbon-components-react
Browser
Chrome
Package version
carbon-components v10.53.0, carbon-components-react v7.53.0
React version
v16.14.0
Description
In high contrast mode with dark theme (e.g. carbon-theme--g90), a ghost button with
hasIconOnly
is not filled in the correct color.Expected:
Ghost button icon should be filled in the text color.
Actual:
Ghost button icon is filled in black while tertiary button is correctly filled in the text color.
It's because ghost button is overwritten by
fill: ButtonText
.#10199 is relevant (or duplicate).
Reproduction/example
https://codesandbox.io/s/tearsheet-example-forked-hlzepj
Steps to reproduce
Enable high contrast mode in your OS.
I take macOS Monterey for example. Open System Preference and tick "Increase contrast" in Accessibility > Display.
Open the codesandbox example and set Gray 90 for the theme.
Code of Conduct
The text was updated successfully, but these errors were encountered: