Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: IconButton right padding is off #11295

Closed
2 tasks done
jnm2377 opened this issue Apr 26, 2022 · 0 comments · Fixed by #11352
Closed
2 tasks done

[Bug]: IconButton right padding is off #11295

jnm2377 opened this issue Apr 26, 2022 · 0 comments · Fixed by #11352
Assignees
@jnm2377
Labels
severity: 1 https://ibm.biz/carbon-severity type: bug 🐛
Milestone
2022 Q2

Comments

@jnm2377
Copy link
Contributor

jnm2377 commented Apr 26, 2022

Package

@carbon/react

Browser

Chrome

Package version

1.1.0

React version

No response

Description

the new IconButton appears to have the wrong right padding.
It seems to be using md btn padding (which is calculated differently).
Screen Shot 2022-04-26 at 6 22 15 PM

CodeSandbox example

https://react.carbondesignsystem.com/?path=/story/components-iconbutton--playground

Steps to reproduce

https://react.carbondesignsystem.com/?path=/story/components-iconbutton--playground

Code of Conduct
@tay1orjones tay1orjones added severity: 1 https://ibm.biz/carbon-severity impact: high 😱 labels Apr 27, 2022
@tay1orjones tay1orjones moved this to ⏱ Backlog in Design System Apr 27, 2022
@tay1orjones tay1orjones added this to the 2022 Q2 milestone Apr 27, 2022
@jnm2377 jnm2377 moved this from ⏱ Backlog to 🏗 In Progress in Design System Apr 28, 2022
@jnm2377 jnm2377 mentioned this issue May 5, 2022
Merged
@jnm2377 jnm2377 moved this from 🏗 In Progress to ✅ Done in Design System May 5, 2022
@kodiakhq kodiakhq bot closed this as completed in #11352 May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnm2377 jnm2377

Labels
severity: 1 https://ibm.biz/carbon-severity type: bug 🐛
Projects
Design System
Archived in project
Milestone
2022 Q2
Development

Successfully merging a pull request may close this issue.

fix(IconButton): adds hasIconOnly classname to fix right padding jnm2377/carbon
2 participants
@tay1orjones @jnm2377