Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable storybook percy integration #11051

Closed
1 of 5 tasks
tay1orjones opened this issue Mar 23, 2022 · 3 comments
Closed
1 of 5 tasks

Re-enable storybook percy integration #11051

tay1orjones opened this issue Mar 23, 2022 · 3 comments

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Mar 23, 2022

In addition to the manually configured e2e tests that provide percy snapshots, we can enable the storybook integration to automatically snapshot stories. This will immediately provide a much higher level of coverage in regards to visual regressions.

@tay1orjones tay1orjones moved this to 🕵️‍♀️ Triage in Design System Mar 23, 2022
@tay1orjones tay1orjones added this to the 2022 Q2 milestone Mar 23, 2022
@tay1orjones
Copy link
Member Author

It's looking more and more like we can do most of what we want via storybook's runner: https://storybook.js.org/blog/test-component-interactions-with-storybook/

Here's a recipe for how to run it in CI https://storybook.js.org/blog/test-component-interactions-with-storybook/

We could probably use the experimental hooks to snapshot before and after the play function https://github.com/storybookjs/test-runner#experimental-test-hook-api

@tay1orjones
Copy link
Member Author

This could either augment or replace the existing plan to add percy visual snapshots to all components #8911

@joshblack
Copy link
Contributor

I believe this was closed by the work completed in #11252! Instead of enabling the storybook percy integration, we are explicitly snapshotting stories through Playwright

Repository owner moved this from 🕵️‍♀️ Triage to ✅ Done in Design System May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants