Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]: Is there OOB support for text editor? #10320

Closed
1 task done
lordsfantasy opened this issue Dec 21, 2021 · 4 comments
Closed
1 task done

[Question]: Is there OOB support for text editor? #10320

lordsfantasy opened this issue Dec 21, 2021 · 4 comments

Comments

@lordsfantasy
Copy link

Question for Carbon

Does carbon provide the following component/pattern?
https://www.carbondesignsystem.com/patterns/text-toolbar-pattern/

Or the above article is more like a guideline to the designer?

Code of Conduct

@jnm2377
Copy link
Contributor

jnm2377 commented Jan 20, 2022

Hi @lordsfantasy thanks for opening this issue! To answer your question, we don't have a component for that. The pattern was actually contributed by a community member here: #2447 We were interested in the component for sure, but don't have the bandwidth/priority for it, so we just added it as a pattern. We'd love to have someone contribute the code for it.

@lordsfantasy
Copy link
Author

Hey @jnm2377, thanks for sharing the #2247. It was super fun going through the backstory and how it evolved into the pattern that it is today.

We used draftjs in our project and modified its design as per the text toolbar pattern. I wouldn't say we achieved 100% design though. The carbon text toolbar pattern functionality seems so much more polished and thoughtfully designed.

If we have to contribute the code, how should we go about it? What should be the underlying editor?

@tay1orjones
Copy link
Member

@lordsfantasy To my knowledge we don't have any data surrounding teams' usage of editor solutions. It would be a total shot in the dark.

I think it would be ideal for the components to not be tied to any specific editor. We could potentially bring in an editor in the storybook environment to wire it all up as an example though.

@laurenmrice
Copy link
Member

Correct, most of our patterns do not have code tied to them and they are mostly mean for design guidelines and best practices. Going to close 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants