Skip to content

Commit

Permalink
fix(button): ensure rem in variable definition level (#6470)
Browse files Browse the repository at this point in the history
This change makes sure `rem` unit is used in variable definition level
(as it's done for other variables).

Fixes #6469.

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
  • Loading branch information
asudoh and kodiakhq[bot] authored Jul 15, 2020
1 parent c4fa71d commit ba5afb6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/components/src/components/button/_mixins.scss
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
justify-content: space-between;
vertical-align: top;
flex-shrink: 0;
min-height: rem($button-height);
min-height: $button-height;
padding: $button-padding;
border-radius: $button-border-radius;
text-align: left;
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/globals/scss/_theme-tokens.scss
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ $button-border-radius: 0 !default;
/// @type Number
/// @access public
/// @group button
$button-height: 48px !default;
$button-height: 3rem !default;

/// @type Value
/// @access public
Expand Down

0 comments on commit ba5afb6

Please sign in to comment.