fix(Tab): implement renderButton support (#7418)

* fix(Tab): implement renderButton support * chore: update snapshot Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
carbon-design-system · Dec 8, 2020 · b39e260 · b39e260
1 parent 1c7fbf6
commit b39e260
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/packages/react/__tests__/__snapshots__/PublicAPI-test.js.snap b/packages/react/__tests__/__snapshots__/PublicAPI-test.js.snap
@@ -5046,6 +5046,9 @@ Map {
         "type": "func",
       },
       "renderAnchor": [Function],
+      "renderButton": Object {
+        "type": "func",
+      },
       "renderContent": Object {
         "type": "func",
       },

diff --git a/packages/react/src/components/Tab/Tab.js b/packages/react/src/components/Tab/Tab.js
@@ -73,6 +73,7 @@ export default class Tab extends React.Component {
      * side router libraries.
      **/
     renderAnchor: deprecate(PropTypes.func),
+    renderButton: PropTypes.func,
 
     /*
      * An optional parameter to allow overriding the content rendering.
@@ -119,7 +120,8 @@ export default class Tab extends React.Component {
       onClick,
       onKeyDown,
       // TODO: rename renderAnchor to renderButton in next major version
-      renderAnchor: renderButton,
+      renderAnchor,
+      renderButton,
       renderContent, // eslint-disable-line no-unused-vars
       ...other
     } = this.props;
@@ -153,6 +155,8 @@ export default class Tab extends React.Component {
       },
     };
 
+    const renderElement = renderButton || renderAnchor;
+
     return (
       <li
         {...other}
@@ -176,8 +180,8 @@ export default class Tab extends React.Component {
           onKeyDown(evt);
         }}
         role="presentation">
-        {renderButton ? (
-          renderButton(buttonProps)
+        {renderElement ? (
+          renderElement(buttonProps)
         ) : (
           <button type="button" role="tab" {...buttonProps}>
             {label}