fix(BreadcrumbItem): remove href check for children of type string (#…

…9226) Co-authored-by: Andrea N. Cardona <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
carbon-design-system · Jul 30, 2021 · 958da95 · 958da95
1 parent dfeb4d4
commit 958da95
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/packages/react/src/components/Breadcrumb/Breadcrumb-story.js b/packages/react/src/components/Breadcrumb/Breadcrumb-story.js
@@ -37,6 +37,7 @@ export const breadcrumb = () => (
     </BreadcrumbItem>
     <BreadcrumbItem href="#">Breadcrumb 2</BreadcrumbItem>
     <BreadcrumbItem href="#">Breadcrumb 3</BreadcrumbItem>
+    <BreadcrumbItem>Breadcrumb 4</BreadcrumbItem>
   </Breadcrumb>
 );
 
@@ -53,6 +54,7 @@ export const breadcrumbWithOverflowMenu = () => (
       </OverflowMenu>
     </BreadcrumbItem>
     <BreadcrumbItem href="#">Breadcrumb 5</BreadcrumbItem>
+    <BreadcrumbItem>Breadcrumb 6</BreadcrumbItem>
   </Breadcrumb>
 );
 
@@ -74,5 +76,6 @@ export const playground = () => (
     <BreadcrumbItem href="#" {...props()}>
       Breadcrumb 3
     </BreadcrumbItem>
+    <BreadcrumbItem>Breadcrumb 4</BreadcrumbItem>
   </Breadcrumb>
 );
diff --git a/packages/react/src/components/Breadcrumb/BreadcrumbItem.js b/packages/react/src/components/Breadcrumb/BreadcrumbItem.js
@@ -53,12 +53,16 @@ const BreadcrumbItem = React.forwardRef(function BreadcrumbItem(
     );
   }
 
-  if (typeof children === 'string' && href) {
+  if (typeof children === 'string') {
     return (
       <li className={className} ref={ref} {...rest}>
-        <Link href={href} aria-current={ariaCurrent}>
-          {children}
-        </Link>
+        {href ? (
+          <Link href={href} aria-current={ariaCurrent}>
+            {children}
+          </Link>
+        ) : (
+          <span className={`${prefix}--link`}>{children}</span>
+        )}
       </li>
     );
   }