From 8c653782a3364b877e47176243de1e0aaaefd67d Mon Sep 17 00:00:00 2001 From: anjaly0606 <99959496+anjaly0606@users.noreply.github.com> Date: Sat, 23 Mar 2024 01:13:00 +0530 Subject: [PATCH 1/8] fix(datepicker): add icon-disabled fill for disabled state (#16032) Co-authored-by: Taylor Jones --- .all-contributorsrc | 9 +++++++++ README.md | 1 + .../styles/scss/components/date-picker/_date-picker.scss | 1 + 3 files changed, 11 insertions(+) diff --git a/.all-contributorsrc b/.all-contributorsrc index 7a699c1bc6b1..cb4fe6340ebe 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -1461,6 +1461,15 @@ "contributions": [ "code" ] + }, + { + "login": "anjaly0606", + "name": "anjaly0606", + "avatar_url": "https://avatars.githubusercontent.com/u/99959496?v=4", + "profile": "https://github.com/anjaly0606", + "contributions": [ + "code" + ] } ], "commitConvention": "none" diff --git a/README.md b/README.md index a510686f560e..e2aa6524ef13 100644 --- a/README.md +++ b/README.md @@ -281,6 +281,7 @@ check out our [Contributing Guide](/.github/CONTRIBUTING.md) and our
Daniel Adebonojo
📖
Anjana M R
💻
Joseph Schultz
💻 +
anjaly0606
💻 diff --git a/packages/styles/scss/components/date-picker/_date-picker.scss b/packages/styles/scss/components/date-picker/_date-picker.scss index e43aa91dc16a..b6623751b792 100644 --- a/packages/styles/scss/components/date-picker/_date-picker.scss +++ b/packages/styles/scss/components/date-picker/_date-picker.scss @@ -177,6 +177,7 @@ .#{$prefix}--date-picker__input:disabled ~ .#{$prefix}--date-picker__icon { cursor: not-allowed; + fill: $icon-disabled; } .#{$prefix}--date-picker--range From 21388d91fedbc0be23caf4fcadf45e56a9428b1a Mon Sep 17 00:00:00 2001 From: Taylor Jones Date: Mon, 25 Mar 2024 12:15:38 -0500 Subject: [PATCH 2/8] docs(style): add guidance on avoiding magic numbers (#15995) * docs(style): add guidance on avoiding magic numbers * docs(style): update image * docs(style): update property * docs(constants): avoid file-local constants --------- Co-authored-by: Alison Joseph --- docs/style.md | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/docs/style.md b/docs/style.md index f42095cc85f6..c3cbea2c0218 100644 --- a/docs/style.md +++ b/docs/style.md @@ -863,6 +863,41 @@ this project: - [Motion](../packages/motion/docs/sass.md) - [Type](../packages/type/docs/sass.md) +##### Avoid magic numbers + +In addition to using design tokens where appropriate, when authoring values for +margin, padding, size, or similar, avoid using +[magic numbers](https://csswizardry.com/2012/11/code-smells-in-css/#magic-numbers). + +> "A magic number is a value that is used ‘because it just works’." + +Magic numbers should be replaced with a value derived from its discrete parts +that have been added together or combined. For example: + +![text-input-style-structure-fixed](https://github.com/carbon-design-system/carbon/assets/3360588/71e4222e-ff96-4dce-b80f-a0626f47cf21) + +If we were trying to apply a `padding-inline-end` to the input to ensure the +input text does not flow behind the icon, we could add up the individual parts +of this that use spacing tokens, contextual layout tokens, or other +constants/variables within the system that will inherently explain what the +final number is composed of. + +```diff +- padding-inline-end: to-rem(32px); ++ padding-inline-end: calc(layout.density('padding-inline') + $icon-size-01); +``` + +When crafting these combinations, avoid creating file-local constants/variables, +especially if they are never reused. Instead: + +1. Check the reusable/global constants for an appropriate one given what is + trying to be accomplished. +2. If one exists, use it. If not, start a conversation with the team as to why + no such value currently exists (perhaps challenge the way it was intended to + be used in the first place). +3. Decide to either introduce a new constant to meet the need; or rework the + code in question to use other constants (or perhaps none at all). + #### Avoid nesting selectors Nesting selectors is often a convenient and fast way to author styles in Sass. From 4e0c7c56e1217ff9b73042006e4ea1d12a39e769 Mon Sep 17 00:00:00 2001 From: "carbon-automation[bot]" <103539138+carbon-automation[bot]@users.noreply.github.com> Date: Tue, 26 Mar 2024 00:03:43 -0700 Subject: [PATCH 3/8] chore(release): 11.54.0-rc.0 (#16048) Co-authored-by: andreancardona <32720851+andreancardona@users.noreply.github.com> --- config/eslint-config-carbon/package.json | 2 +- examples/class-prefix/package.json | 4 +- examples/codesandbox-styles/package.json | 4 +- examples/custom-theme/package.json | 4 +- examples/id-prefix/package.json | 4 +- .../incremental-migration-vite/package.json | 4 +- examples/light-dark-mode/package.json | 4 +- examples/nextjs/package.json | 4 +- examples/v10-token-compat-in-v11/package.json | 4 +- examples/vite/package.json | 4 +- packages/carbon-components-react/package.json | 6 +- packages/carbon-components/package.json | 4 +- packages/elements/package.json | 6 +- packages/feature-flags/package.json | 2 +- packages/icon-build-helpers/package.json | 2 +- packages/icons-react/package.json | 6 +- packages/icons-vue/package.json | 4 +- packages/icons/package.json | 4 +- packages/pictograms-react/package.json | 6 +- packages/pictograms/package.json | 4 +- packages/react/package.json | 10 +-- packages/styles/package.json | 6 +- packages/themes/package.json | 2 +- www/package.json | 4 +- yarn.lock | 72 +++++++++---------- 25 files changed, 88 insertions(+), 88 deletions(-) diff --git a/config/eslint-config-carbon/package.json b/config/eslint-config-carbon/package.json index 82fa4f2527ca..e9befb964fdf 100644 --- a/config/eslint-config-carbon/package.json +++ b/config/eslint-config-carbon/package.json @@ -1,7 +1,7 @@ { "name": "eslint-config-carbon", "description": "ESLint configuration for Carbon", - "version": "3.11.0", + "version": "3.12.0-rc.0", "license": "Apache-2.0", "main": "index.js", "repository": { diff --git a/examples/class-prefix/package.json b/examples/class-prefix/package.json index 47b8d913f729..b3c892518e23 100644 --- a/examples/class-prefix/package.json +++ b/examples/class-prefix/package.json @@ -1,7 +1,7 @@ { "name": "class-prefix", "private": true, - "version": "0.50.0", + "version": "0.51.0-rc.0", "type": "module", "scripts": { "dev": "vite", @@ -9,7 +9,7 @@ "preview": "vite preview" }, "dependencies": { - "@carbon/react": "^1.53.0", + "@carbon/react": "^1.54.0-rc.0", "react": "^18.2.0", "react-dom": "^18.2.0" }, diff --git a/examples/codesandbox-styles/package.json b/examples/codesandbox-styles/package.json index cb4dec4c3db9..ce15b9b92c11 100644 --- a/examples/codesandbox-styles/package.json +++ b/examples/codesandbox-styles/package.json @@ -1,7 +1,7 @@ { "name": "codesandbox-styles", "private": true, - "version": "0.56.0", + "version": "0.57.0-rc.0", "type": "module", "scripts": { "dev": "vite" @@ -11,6 +11,6 @@ "vite": "^4.3.8" }, "dependencies": { - "@carbon/styles": "^1.53.0" + "@carbon/styles": "^1.54.0-rc.0" } } diff --git a/examples/custom-theme/package.json b/examples/custom-theme/package.json index ae80a8010cdb..0e6e3b251591 100644 --- a/examples/custom-theme/package.json +++ b/examples/custom-theme/package.json @@ -1,7 +1,7 @@ { "name": "custom-theme", "private": true, - "version": "0.51.0", + "version": "0.52.0-rc.0", "type": "module", "scripts": { "dev": "vite", @@ -9,7 +9,7 @@ "preview": "vite preview" }, "dependencies": { - "@carbon/react": "^1.53.0", + "@carbon/react": "^1.54.0-rc.0", "react": "^18.2.0", "react-dom": "^18.2.0" }, diff --git a/examples/id-prefix/package.json b/examples/id-prefix/package.json index 2a9f897b5de4..f00670879af6 100644 --- a/examples/id-prefix/package.json +++ b/examples/id-prefix/package.json @@ -1,7 +1,7 @@ { "name": "id-prefix", "private": true, - "version": "0.50.0", + "version": "0.51.0-rc.0", "type": "module", "scripts": { "dev": "vite", @@ -9,7 +9,7 @@ "preview": "vite preview" }, "dependencies": { - "@carbon/react": "^1.53.0", + "@carbon/react": "^1.54.0-rc.0", "react": "^18.2.0", "react-dom": "^18.2.0" }, diff --git a/examples/incremental-migration-vite/package.json b/examples/incremental-migration-vite/package.json index db21dc1a7eeb..6fc989a3704c 100644 --- a/examples/incremental-migration-vite/package.json +++ b/examples/incremental-migration-vite/package.json @@ -1,7 +1,7 @@ { "name": "incremental-migration-vite", "private": true, - "version": "0.18.0", + "version": "0.19.0-rc.0", "scripts": { "dev": "vite", "build": "vite build", @@ -12,7 +12,7 @@ }, "dependencies": { "@carbon/icons-react": "^10.49.0", - "@carbon/react": "^1.53.0", + "@carbon/react": "^1.54.0-rc.0", "carbon-components": "^10.57.0", "carbon-components-react": "^7.57.0", "carbon-icons": "^7.0.7", diff --git a/examples/light-dark-mode/package.json b/examples/light-dark-mode/package.json index 7185942ba05d..698c18713f9c 100644 --- a/examples/light-dark-mode/package.json +++ b/examples/light-dark-mode/package.json @@ -1,7 +1,7 @@ { "name": "examples-light-dark", "private": true, - "version": "0.51.0", + "version": "0.52.0-rc.0", "scripts": { "build": "next build", "dev": "next dev", @@ -9,7 +9,7 @@ "start": "next start" }, "dependencies": { - "@carbon/react": "^1.53.0", + "@carbon/react": "^1.54.0-rc.0", "next": "13.5.1", "react": "18.2.0", "react-dom": "18.2.0" diff --git a/examples/nextjs/package.json b/examples/nextjs/package.json index 5b9a6e857a2c..d4c260ef1a23 100644 --- a/examples/nextjs/package.json +++ b/examples/nextjs/package.json @@ -1,7 +1,7 @@ { "name": "examples-nextjs", "private": true, - "version": "0.53.0", + "version": "0.54.0-rc.0", "scripts": { "build": "next build", "dev": "next dev", @@ -9,7 +9,7 @@ "start": "next start" }, "dependencies": { - "@carbon/react": "^1.53.0", + "@carbon/react": "^1.54.0-rc.0", "next": "13.5.6", "react": "18.2.0", "react-dom": "18.2.0" diff --git a/examples/v10-token-compat-in-v11/package.json b/examples/v10-token-compat-in-v11/package.json index 8c376e4fa112..918a8c4f256d 100644 --- a/examples/v10-token-compat-in-v11/package.json +++ b/examples/v10-token-compat-in-v11/package.json @@ -1,7 +1,7 @@ { "name": "v10-token-compat-in-v11", "private": true, - "version": "0.51.0", + "version": "0.52.0-rc.0", "type": "module", "scripts": { "dev": "vite", @@ -9,7 +9,7 @@ "preview": "vite preview" }, "dependencies": { - "@carbon/react": "^1.53.0", + "@carbon/react": "^1.54.0-rc.0", "react": "^18.2.0", "react-dom": "^18.2.0" }, diff --git a/examples/vite/package.json b/examples/vite/package.json index 9c20abf137a5..992241052c3e 100644 --- a/examples/vite/package.json +++ b/examples/vite/package.json @@ -1,7 +1,7 @@ { "name": "vite", "private": true, - "version": "0.51.0", + "version": "0.52.0-rc.0", "type": "module", "scripts": { "dev": "vite", @@ -9,7 +9,7 @@ "preview": "vite preview" }, "dependencies": { - "@carbon/react": "^1.53.0", + "@carbon/react": "^1.54.0-rc.0", "react": "^18.2.0", "react-dom": "^18.2.0" }, diff --git a/packages/carbon-components-react/package.json b/packages/carbon-components-react/package.json index fb7aff639f38..beb3b642162b 100644 --- a/packages/carbon-components-react/package.json +++ b/packages/carbon-components-react/package.json @@ -1,7 +1,7 @@ { "name": "carbon-components-react", "description": "The Carbon Design System is IBM’s open-source design system for products and experiences.", - "version": "8.53.0", + "version": "8.54.0-rc.0", "license": "Apache-2.0", "main": "lib/index.js", "module": "es/index.js", @@ -42,8 +42,8 @@ "sass": "^1.33.0" }, "dependencies": { - "@carbon/react": "^1.53.0", - "@carbon/styles": "^1.53.0", + "@carbon/react": "^1.54.0-rc.0", + "@carbon/styles": "^1.54.0-rc.0", "@ibm/telemetry-js": "^1.2.1", "chalk": "1.1.3" }, diff --git a/packages/carbon-components/package.json b/packages/carbon-components/package.json index 161047b1cef5..1e516c551f17 100644 --- a/packages/carbon-components/package.json +++ b/packages/carbon-components/package.json @@ -1,7 +1,7 @@ { "name": "carbon-components", "description": "The Carbon Design System is IBM’s open-source design system for products and experiences.", - "version": "11.53.0", + "version": "11.54.0-rc.0", "license": "Apache-2.0", "repository": { "type": "git", @@ -43,7 +43,7 @@ "sass": "^1.33.0" }, "dependencies": { - "@carbon/styles": "^1.53.0", + "@carbon/styles": "^1.54.0-rc.0", "@ibm/telemetry-js": "^1.2.1", "chalk": "1.1.3" }, diff --git a/packages/elements/package.json b/packages/elements/package.json index 29e804bf657d..8391170843a8 100644 --- a/packages/elements/package.json +++ b/packages/elements/package.json @@ -1,7 +1,7 @@ { "name": "@carbon/elements", "description": "A collection of design elements in code for the IBM Design Language", - "version": "11.42.0", + "version": "11.43.0-rc.0", "license": "Apache-2.0", "main": "lib/index.js", "module": "es/index.js", @@ -40,10 +40,10 @@ "dependencies": { "@carbon/colors": "^11.21.0", "@carbon/grid": "^11.22.0", - "@carbon/icons": "^11.38.0", + "@carbon/icons": "^11.39.0-rc.0", "@carbon/layout": "^11.21.0", "@carbon/motion": "^11.17.0", - "@carbon/themes": "^11.33.0", + "@carbon/themes": "^11.34.0-rc.0", "@carbon/type": "^11.26.0", "@ibm/telemetry-js": "^1.2.1" }, diff --git a/packages/feature-flags/package.json b/packages/feature-flags/package.json index 3cea1e6b5eb1..4f552f18c558 100644 --- a/packages/feature-flags/package.json +++ b/packages/feature-flags/package.json @@ -1,7 +1,7 @@ { "name": "@carbon/feature-flags", "description": "Build with feature flags in Carbon", - "version": "0.18.0", + "version": "0.19.0-rc.0", "license": "Apache-2.0", "main": "lib/index.js", "module": "es/index.js", diff --git a/packages/icon-build-helpers/package.json b/packages/icon-build-helpers/package.json index eb1b8ab48bc7..5bf8fac0321a 100644 --- a/packages/icon-build-helpers/package.json +++ b/packages/icon-build-helpers/package.json @@ -2,7 +2,7 @@ "name": "@carbon/icon-build-helpers", "private": true, "description": "Build helpers for the Carbon Design System icon library", - "version": "1.23.0", + "version": "1.24.0-rc.0", "license": "Apache-2.0", "main": "src/index.js", "repository": { diff --git a/packages/icons-react/package.json b/packages/icons-react/package.json index f1a416916e02..de8eae213c75 100644 --- a/packages/icons-react/package.json +++ b/packages/icons-react/package.json @@ -1,7 +1,7 @@ { "name": "@carbon/icons-react", "description": "React components for icons in digital and software products using the Carbon Design System", - "version": "11.38.0", + "version": "11.39.0-rc.0", "license": "Apache-2.0", "main": "lib/index.js", "module": "es/index.js", @@ -43,8 +43,8 @@ "prop-types": "^15.7.2" }, "devDependencies": { - "@carbon/icon-build-helpers": "^1.23.0", - "@carbon/icons": "^11.38.0", + "@carbon/icon-build-helpers": "^1.24.0-rc.0", + "@carbon/icons": "^11.39.0-rc.0", "rimraf": "^5.0.0" }, "sideEffects": false diff --git a/packages/icons-vue/package.json b/packages/icons-vue/package.json index ab3455d6adc0..2a9fc563f99e 100644 --- a/packages/icons-vue/package.json +++ b/packages/icons-vue/package.json @@ -1,7 +1,7 @@ { "name": "@carbon/icons-vue", "description": "Vue components for icons in digital and software products using the Carbon Design System", - "version": "10.87.0", + "version": "10.88.0-rc.0", "license": "Apache-2.0", "main": "lib/index.js", "module": "es/index.js", @@ -35,7 +35,7 @@ }, "devDependencies": { "@carbon/cli-reporter": "^10.7.0", - "@carbon/icons": "^11.38.0", + "@carbon/icons": "^11.39.0-rc.0", "fs-extra": "^11.0.0", "prettier": "^2.8.8", "rimraf": "^5.0.0", diff --git a/packages/icons/package.json b/packages/icons/package.json index da267b2af5e2..4c1e2e61572e 100644 --- a/packages/icons/package.json +++ b/packages/icons/package.json @@ -1,7 +1,7 @@ { "name": "@carbon/icons", "description": "Icons for digital and software products using the Carbon Design System", - "version": "11.38.0", + "version": "11.39.0-rc.0", "license": "Apache-2.0", "main": "lib/index.js", "module": "es/index.js", @@ -42,7 +42,7 @@ }, "devDependencies": { "@carbon/cli": "^11.16.0", - "@carbon/icon-build-helpers": "^1.23.0", + "@carbon/icon-build-helpers": "^1.24.0-rc.0", "rimraf": "^5.0.0" }, "dependencies": { diff --git a/packages/pictograms-react/package.json b/packages/pictograms-react/package.json index 53ca82d85e44..642f0d958fcd 100644 --- a/packages/pictograms-react/package.json +++ b/packages/pictograms-react/package.json @@ -1,7 +1,7 @@ { "name": "@carbon/pictograms-react", "description": "React components for pictograms in digital and software products using the Carbon Design System", - "version": "11.58.0", + "version": "11.59.0-rc.0", "license": "Apache-2.0", "main": "lib/index.js", "module": "es/index.js", @@ -44,8 +44,8 @@ "prop-types": "^15.7.2" }, "devDependencies": { - "@carbon/icon-build-helpers": "^1.23.0", - "@carbon/pictograms": "^12.32.0", + "@carbon/icon-build-helpers": "^1.24.0-rc.0", + "@carbon/pictograms": "^12.33.0-rc.0", "rimraf": "^5.0.0" }, "sideEffects": false diff --git a/packages/pictograms/package.json b/packages/pictograms/package.json index 337dc1695fcd..ee04671138c3 100644 --- a/packages/pictograms/package.json +++ b/packages/pictograms/package.json @@ -1,7 +1,7 @@ { "name": "@carbon/pictograms", "description": "Pictograms for digital and software products using the Carbon Design System", - "version": "12.32.0", + "version": "12.33.0-rc.0", "license": "Apache-2.0", "main": "lib/index.js", "module": "es/index.js", @@ -33,7 +33,7 @@ "postinstall": "ibmtelemetry --config=telemetry.yml" }, "devDependencies": { - "@carbon/icon-build-helpers": "^1.23.0", + "@carbon/icon-build-helpers": "^1.24.0-rc.0", "rimraf": "^5.0.0" }, "dependencies": { diff --git a/packages/react/package.json b/packages/react/package.json index d489f535a2cf..0f56fc6bb711 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -1,7 +1,7 @@ { "name": "@carbon/react", "description": "React components for the Carbon Design System", - "version": "1.53.0", + "version": "1.54.0-rc.0", "license": "Apache-2.0", "main": "lib/index.js", "module": "es/index.js", @@ -48,10 +48,10 @@ }, "dependencies": { "@babel/runtime": "^7.18.3", - "@carbon/feature-flags": "^0.18.0", - "@carbon/icons-react": "^11.38.0", + "@carbon/feature-flags": "^0.19.0-rc.0", + "@carbon/icons-react": "^11.39.0-rc.0", "@carbon/layout": "^11.21.0", - "@carbon/styles": "^1.53.0", + "@carbon/styles": "^1.54.0-rc.0", "@floating-ui/react": "^0.25.4", "@ibm/telemetry-js": "^1.2.1", "classnames": "2.5.1", @@ -81,7 +81,7 @@ "@babel/preset-react": "^7.22.3", "@babel/preset-typescript": "^7.21.5", "@carbon/test-utils": "^10.30.0", - "@carbon/themes": "^11.33.0", + "@carbon/themes": "^11.34.0-rc.0", "@rollup/plugin-babel": "^6.0.0", "@rollup/plugin-commonjs": "^25.0.0", "@rollup/plugin-node-resolve": "^15.0.0", diff --git a/packages/styles/package.json b/packages/styles/package.json index df8b43d616c6..b192a862dec7 100644 --- a/packages/styles/package.json +++ b/packages/styles/package.json @@ -1,7 +1,7 @@ { "name": "@carbon/styles", "description": "Styles for the Carbon Design System", - "version": "1.53.0", + "version": "1.54.0-rc.0", "license": "Apache-2.0", "repository": { "type": "git", @@ -41,11 +41,11 @@ }, "dependencies": { "@carbon/colors": "^11.21.0", - "@carbon/feature-flags": "^0.18.0", + "@carbon/feature-flags": "^0.19.0-rc.0", "@carbon/grid": "^11.22.0", "@carbon/layout": "^11.21.0", "@carbon/motion": "^11.17.0", - "@carbon/themes": "^11.33.0", + "@carbon/themes": "^11.34.0-rc.0", "@carbon/type": "^11.26.0", "@ibm/plex": "6.0.0-next.6", "@ibm/telemetry-js": "^1.2.1" diff --git a/packages/themes/package.json b/packages/themes/package.json index 10623806ee02..fb9313f52f94 100644 --- a/packages/themes/package.json +++ b/packages/themes/package.json @@ -1,7 +1,7 @@ { "name": "@carbon/themes", "description": "Themes for applying color in the Carbon Design System", - "version": "11.33.0", + "version": "11.34.0-rc.0", "license": "Apache-2.0", "main": "lib/index.js", "module": "es/index.js", diff --git a/www/package.json b/www/package.json index adfc117ff836..0c38b17dacd2 100644 --- a/www/package.json +++ b/www/package.json @@ -1,7 +1,7 @@ { "name": "www", "private": true, - "version": "0.62.0", + "version": "0.63.0-rc.0", "license": "Apache-2.0", "repository": { "type": "git", @@ -22,7 +22,7 @@ "start": "next start" }, "dependencies": { - "@carbon/react": "^1.53.0", + "@carbon/react": "^1.54.0-rc.0", "@octokit/core": "^4.0.0", "@octokit/plugin-retry": "^3.0.9", "@octokit/plugin-throttling": "^4.0.0", diff --git a/yarn.lock b/yarn.lock index 419cd6a01fdf..f64d1eb72424 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1830,10 +1830,10 @@ __metadata: "@carbon/cli": "npm:^11.16.0" "@carbon/colors": "npm:^11.21.0" "@carbon/grid": "npm:^11.22.0" - "@carbon/icons": "npm:^11.38.0" + "@carbon/icons": "npm:^11.39.0-rc.0" "@carbon/layout": "npm:^11.21.0" "@carbon/motion": "npm:^11.17.0" - "@carbon/themes": "npm:^11.33.0" + "@carbon/themes": "npm:^11.34.0-rc.0" "@carbon/type": "npm:^11.26.0" "@ibm/telemetry-js": "npm:^1.2.1" fs-extra: "npm:^11.0.0" @@ -1843,7 +1843,7 @@ __metadata: languageName: unknown linkType: soft -"@carbon/feature-flags@npm:^0.18.0, @carbon/feature-flags@workspace:packages/feature-flags": +"@carbon/feature-flags@npm:^0.19.0-rc.0, @carbon/feature-flags@workspace:packages/feature-flags": version: 0.0.0-use.local resolution: "@carbon/feature-flags@workspace:packages/feature-flags" dependencies: @@ -1883,7 +1883,7 @@ __metadata: languageName: unknown linkType: soft -"@carbon/icon-build-helpers@npm:^1.23.0, @carbon/icon-build-helpers@workspace:packages/icon-build-helpers": +"@carbon/icon-build-helpers@npm:^1.24.0-rc.0, @carbon/icon-build-helpers@workspace:packages/icon-build-helpers": version: 0.0.0-use.local resolution: "@carbon/icon-build-helpers@workspace:packages/icon-build-helpers" dependencies: @@ -1943,13 +1943,13 @@ __metadata: languageName: node linkType: hard -"@carbon/icons-react@npm:^11.38.0, @carbon/icons-react@workspace:packages/icons-react": +"@carbon/icons-react@npm:^11.39.0-rc.0, @carbon/icons-react@workspace:packages/icons-react": version: 0.0.0-use.local resolution: "@carbon/icons-react@workspace:packages/icons-react" dependencies: - "@carbon/icon-build-helpers": "npm:^1.23.0" + "@carbon/icon-build-helpers": "npm:^1.24.0-rc.0" "@carbon/icon-helpers": "npm:^10.47.0" - "@carbon/icons": "npm:^11.38.0" + "@carbon/icons": "npm:^11.39.0-rc.0" "@ibm/telemetry-js": "npm:^1.2.1" prop-types: "npm:^15.7.2" rimraf: "npm:^5.0.0" @@ -1964,7 +1964,7 @@ __metadata: dependencies: "@carbon/cli-reporter": "npm:^10.7.0" "@carbon/icon-helpers": "npm:^10.47.0" - "@carbon/icons": "npm:^11.38.0" + "@carbon/icons": "npm:^11.39.0-rc.0" "@ibm/telemetry-js": "npm:^1.2.1" fs-extra: "npm:^11.0.0" prettier: "npm:^2.8.8" @@ -1974,12 +1974,12 @@ __metadata: languageName: unknown linkType: soft -"@carbon/icons@npm:^11.38.0, @carbon/icons@workspace:packages/icons": +"@carbon/icons@npm:^11.39.0-rc.0, @carbon/icons@workspace:packages/icons": version: 0.0.0-use.local resolution: "@carbon/icons@workspace:packages/icons" dependencies: "@carbon/cli": "npm:^11.16.0" - "@carbon/icon-build-helpers": "npm:^1.23.0" + "@carbon/icon-build-helpers": "npm:^1.24.0-rc.0" "@ibm/telemetry-js": "npm:^1.2.1" rimraf: "npm:^5.0.0" languageName: unknown @@ -2020,9 +2020,9 @@ __metadata: version: 0.0.0-use.local resolution: "@carbon/pictograms-react@workspace:packages/pictograms-react" dependencies: - "@carbon/icon-build-helpers": "npm:^1.23.0" + "@carbon/icon-build-helpers": "npm:^1.24.0-rc.0" "@carbon/icon-helpers": "npm:^10.47.0" - "@carbon/pictograms": "npm:^12.32.0" + "@carbon/pictograms": "npm:^12.33.0-rc.0" "@ibm/telemetry-js": "npm:^1.2.1" prop-types: "npm:^15.7.2" rimraf: "npm:^5.0.0" @@ -2031,17 +2031,17 @@ __metadata: languageName: unknown linkType: soft -"@carbon/pictograms@npm:^12.32.0, @carbon/pictograms@workspace:packages/pictograms": +"@carbon/pictograms@npm:^12.33.0-rc.0, @carbon/pictograms@workspace:packages/pictograms": version: 0.0.0-use.local resolution: "@carbon/pictograms@workspace:packages/pictograms" dependencies: - "@carbon/icon-build-helpers": "npm:^1.23.0" + "@carbon/icon-build-helpers": "npm:^1.24.0-rc.0" "@ibm/telemetry-js": "npm:^1.2.1" rimraf: "npm:^5.0.0" languageName: unknown linkType: soft -"@carbon/react@npm:^1.53.0, @carbon/react@workspace:packages/react": +"@carbon/react@npm:^1.54.0-rc.0, @carbon/react@workspace:packages/react": version: 0.0.0-use.local resolution: "@carbon/react@workspace:packages/react" dependencies: @@ -2054,12 +2054,12 @@ __metadata: "@babel/preset-react": "npm:^7.22.3" "@babel/preset-typescript": "npm:^7.21.5" "@babel/runtime": "npm:^7.18.3" - "@carbon/feature-flags": "npm:^0.18.0" - "@carbon/icons-react": "npm:^11.38.0" + "@carbon/feature-flags": "npm:^0.19.0-rc.0" + "@carbon/icons-react": "npm:^11.39.0-rc.0" "@carbon/layout": "npm:^11.21.0" - "@carbon/styles": "npm:^1.53.0" + "@carbon/styles": "npm:^1.54.0-rc.0" "@carbon/test-utils": "npm:^10.30.0" - "@carbon/themes": "npm:^11.33.0" + "@carbon/themes": "npm:^11.34.0-rc.0" "@floating-ui/react": "npm:^0.25.4" "@ibm/telemetry-js": "npm:^1.2.1" "@rollup/plugin-babel": "npm:^6.0.0" @@ -2139,17 +2139,17 @@ __metadata: languageName: unknown linkType: soft -"@carbon/styles@npm:^1.53.0, @carbon/styles@workspace:packages/styles": +"@carbon/styles@npm:^1.54.0-rc.0, @carbon/styles@workspace:packages/styles": version: 0.0.0-use.local resolution: "@carbon/styles@workspace:packages/styles" dependencies: "@carbon/colors": "npm:^11.21.0" - "@carbon/feature-flags": "npm:^0.18.0" + "@carbon/feature-flags": "npm:^0.19.0-rc.0" "@carbon/grid": "npm:^11.22.0" "@carbon/layout": "npm:^11.21.0" "@carbon/motion": "npm:^11.17.0" "@carbon/test-utils": "npm:^10.30.0" - "@carbon/themes": "npm:^11.33.0" + "@carbon/themes": "npm:^11.34.0-rc.0" "@carbon/type": "npm:^11.26.0" "@ibm/plex": "npm:6.0.0-next.6" "@ibm/telemetry-js": "npm:^1.2.1" @@ -2193,7 +2193,7 @@ __metadata: languageName: unknown linkType: soft -"@carbon/themes@npm:^11.33.0, @carbon/themes@workspace:packages/themes": +"@carbon/themes@npm:^11.34.0-rc.0, @carbon/themes@workspace:packages/themes": version: 0.0.0-use.local resolution: "@carbon/themes@workspace:packages/themes" dependencies: @@ -9944,8 +9944,8 @@ __metadata: "@babel/plugin-transform-react-constant-elements": "npm:^7.17.12" "@babel/preset-env": "npm:^7.18.2" "@babel/preset-react": "npm:^7.17.12" - "@carbon/react": "npm:^1.53.0" - "@carbon/styles": "npm:^1.53.0" + "@carbon/react": "npm:^1.54.0-rc.0" + "@carbon/styles": "npm:^1.54.0-rc.0" "@carbon/test-utils": "npm:^10.30.0" "@ibm/telemetry-js": "npm:^1.2.1" "@rollup/plugin-babel": "npm:^6.0.0" @@ -9984,7 +9984,7 @@ __metadata: version: 0.0.0-use.local resolution: "carbon-components@workspace:packages/carbon-components" dependencies: - "@carbon/styles": "npm:^1.53.0" + "@carbon/styles": "npm:^1.54.0-rc.0" "@carbon/test-utils": "npm:^10.30.0" "@ibm/telemetry-js": "npm:^1.2.1" chalk: "npm:1.1.3" @@ -10334,7 +10334,7 @@ __metadata: version: 0.0.0-use.local resolution: "class-prefix@workspace:examples/class-prefix" dependencies: - "@carbon/react": "npm:^1.53.0" + "@carbon/react": "npm:^1.54.0-rc.0" "@vitejs/plugin-react": "npm:4.0.0" react: "npm:^18.2.0" react-dom: "npm:^18.2.0" @@ -10645,7 +10645,7 @@ __metadata: version: 0.0.0-use.local resolution: "codesandbox-styles@workspace:examples/codesandbox-styles" dependencies: - "@carbon/styles": "npm:^1.53.0" + "@carbon/styles": "npm:^1.54.0-rc.0" sass: "npm:^1.51.0" vite: "npm:^4.3.8" languageName: unknown @@ -11689,7 +11689,7 @@ __metadata: version: 0.0.0-use.local resolution: "custom-theme@workspace:examples/custom-theme" dependencies: - "@carbon/react": "npm:^1.53.0" + "@carbon/react": "npm:^1.54.0-rc.0" "@vitejs/plugin-react": "npm:4.0.0" react: "npm:^18.2.0" react-dom: "npm:^18.2.0" @@ -13774,7 +13774,7 @@ __metadata: version: 0.0.0-use.local resolution: "examples-light-dark@workspace:examples/light-dark-mode" dependencies: - "@carbon/react": "npm:^1.53.0" + "@carbon/react": "npm:^1.54.0-rc.0" eslint: "npm:8.40.0" next: "npm:13.5.1" react: "npm:18.2.0" @@ -13787,7 +13787,7 @@ __metadata: version: 0.0.0-use.local resolution: "examples-nextjs@workspace:examples/nextjs" dependencies: - "@carbon/react": "npm:^1.53.0" + "@carbon/react": "npm:^1.54.0-rc.0" eslint: "npm:8.40.0" eslint-config-next: "npm:13.4.7" next: "npm:13.5.6" @@ -15943,7 +15943,7 @@ __metadata: version: 0.0.0-use.local resolution: "id-prefix@workspace:examples/id-prefix" dependencies: - "@carbon/react": "npm:^1.53.0" + "@carbon/react": "npm:^1.54.0-rc.0" "@vitejs/plugin-react": "npm:4.0.0" react: "npm:^18.2.0" react-dom: "npm:^18.2.0" @@ -16057,7 +16057,7 @@ __metadata: resolution: "incremental-migration-vite@workspace:examples/incremental-migration-vite" dependencies: "@carbon/icons-react": "npm:^10.49.0" - "@carbon/react": "npm:^1.53.0" + "@carbon/react": "npm:^1.54.0-rc.0" "@vitejs/plugin-react": "npm:4.0.0" carbon-components: "npm:^10.57.0" carbon-components-react: "npm:^7.57.0" @@ -27777,7 +27777,7 @@ __metadata: version: 0.0.0-use.local resolution: "v10-token-compat-in-v11@workspace:examples/v10-token-compat-in-v11" dependencies: - "@carbon/react": "npm:^1.53.0" + "@carbon/react": "npm:^1.54.0-rc.0" "@vitejs/plugin-react": "npm:4.0.0" react: "npm:^18.2.0" react-dom: "npm:^18.2.0" @@ -28063,7 +28063,7 @@ __metadata: version: 0.0.0-use.local resolution: "vite@workspace:examples/vite" dependencies: - "@carbon/react": "npm:^1.53.0" + "@carbon/react": "npm:^1.54.0-rc.0" "@vitejs/plugin-react": "npm:4.0.0" react: "npm:^18.2.0" react-dom: "npm:^18.2.0" @@ -28633,7 +28633,7 @@ __metadata: version: 0.0.0-use.local resolution: "www@workspace:www" dependencies: - "@carbon/react": "npm:^1.53.0" + "@carbon/react": "npm:^1.54.0-rc.0" "@octokit/core": "npm:^4.0.0" "@octokit/plugin-retry": "npm:^3.0.9" "@octokit/plugin-throttling": "npm:^4.0.0" From f34e52a31d748394950f724dd32ba41dcecde479 Mon Sep 17 00:00:00 2001 From: Guilherme Datilio Ribeiro Date: Tue, 26 Mar 2024 11:26:59 -0300 Subject: [PATCH 4/8] fix: fixed datatable hover with Toggletip (#15965) * fix: fixed datatable hover * fix: change to popover the checker * fix: fixed style --- .../DataTable-batch-actions.stories.js | 59 +++++++++++++++++++ .../components/data-table/_data-table.scss | 10 +++- 2 files changed, 67 insertions(+), 2 deletions(-) diff --git a/packages/react/src/components/DataTable/stories/DataTable-batch-actions.stories.js b/packages/react/src/components/DataTable/stories/DataTable-batch-actions.stories.js index d6cca2fd7ac1..762cfd725d1a 100644 --- a/packages/react/src/components/DataTable/stories/DataTable-batch-actions.stories.js +++ b/packages/react/src/components/DataTable/stories/DataTable-batch-actions.stories.js @@ -29,8 +29,11 @@ import DataTable, { TableToolbarMenu, } from '..'; +import { Toggletip, ToggletipButton, ToggletipContent } from '../../Toggletip'; + import { batchActionClick, rows, headers } from './shared'; import mdx from '../DataTable.mdx'; +import Link from '../../Link'; export default { title: 'Components/DataTable/Batch Actions', @@ -285,6 +288,62 @@ export const Playground = (args) => ( ); +export const Test = () => ( + + {({ + rows, + headers, + getHeaderProps, + getRowProps, + getTableProps, + getTableContainerProps, + }) => ( + + + + + {headers.map((header) => ( + + {header.header} + + ))} + + + + {rows.map((row) => ( + + {row.cells.map((cell) => ( + + + {cell.value} + +

+ Lorem ipsum dolor{' '} + + sit amet + + . +

+ + + + ))} + + ))} + +
+ + )} + +); + Playground.argTypes = { filterRows: { table: { diff --git a/packages/styles/scss/components/data-table/_data-table.scss b/packages/styles/scss/components/data-table/_data-table.scss index 9ad130ce00b4..123c5ed9157d 100644 --- a/packages/styles/scss/components/data-table/_data-table.scss +++ b/packages/styles/scss/components/data-table/_data-table.scss @@ -120,11 +120,17 @@ color: $text-primary; } - .#{$prefix}--data-table tr:hover .#{$prefix}--link { + .#{$prefix}--data-table + tr + + :not(.#{$prefix}--popover-container):hover + .#{$prefix}--link { color: $link-secondary; } - .#{$prefix}--data-table tr:hover .#{$prefix}--link--disabled { + .#{$prefix}--data-table + tr + + :not(.#{$prefix}--popover-container):hover + .#{$prefix}--link--disabled { color: $text-disabled; } From 46c40293a36d8f9090ab3798cde6110dc03f3151 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 26 Mar 2024 11:55:40 -0700 Subject: [PATCH 5/8] chore(deps): bump actions/deploy-pages from 4.0.4 to 4.0.5 (#16002) Bumps [actions/deploy-pages](https://github.com/actions/deploy-pages) from 4.0.4 to 4.0.5. - [Release notes](https://github.com/actions/deploy-pages/releases) - [Commits](https://github.com/actions/deploy-pages/compare/decdde0ac072f6dcbe43649d82d9c635fff5b4e4...d6db90164ac5ed86f2b6aed7e0febac5b3c0c03e) --- updated-dependencies: - dependency-name: actions/deploy-pages dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/deploy-react-storybook.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/deploy-react-storybook.yml b/.github/workflows/deploy-react-storybook.yml index 9c50f2b8c521..4341a6c9cf3d 100644 --- a/.github/workflows/deploy-react-storybook.yml +++ b/.github/workflows/deploy-react-storybook.yml @@ -63,4 +63,4 @@ jobs: steps: - name: Deploy to GitHub Pages id: deployment - uses: actions/deploy-pages@decdde0ac072f6dcbe43649d82d9c635fff5b4e4 #v4.0.4 + uses: actions/deploy-pages@d6db90164ac5ed86f2b6aed7e0febac5b3c0c03e #v4.0.5 From 6f55ab9eb0ecf832a31e140db979d812d4416989 Mon Sep 17 00:00:00 2001 From: Guilherme Datilio Ribeiro Date: Tue, 26 Mar 2024 18:59:05 -0300 Subject: [PATCH 6/8] fix: fixed style in inline notification (#15973) --- .../notification/_actionable-notification.scss | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/packages/styles/scss/components/notification/_actionable-notification.scss b/packages/styles/scss/components/notification/_actionable-notification.scss index b8ea737133b1..c3569fe4f68b 100644 --- a/packages/styles/scss/components/notification/_actionable-notification.scss +++ b/packages/styles/scss/components/notification/_actionable-notification.scss @@ -190,6 +190,16 @@ opacity: 1; } + .#{$prefix}--actionable-notification--warning + .#{$prefix}--inline-notification__icon + path[opacity='0'], + .#{$prefix}--actionable-notification--warning-alt + .#{$prefix}--inline-notification__icon + path:first-of-type { + fill: $black-100; + opacity: 1; + } + .#{$prefix}--actionable-notification__details { display: flex; flex-grow: 1; From bbc918173cf7fa4d21afa98ddee4ce01ea57d702 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 26 Mar 2024 15:01:37 -0700 Subject: [PATCH 7/8] chore(deps): bump actions/add-to-project from 0.6.0 to 0.6.1 (#16013) Bumps [actions/add-to-project](https://github.com/actions/add-to-project) from 0.6.0 to 0.6.1. - [Release notes](https://github.com/actions/add-to-project/releases) - [Commits](https://github.com/actions/add-to-project/compare/0609a2702eefb44781da00f8e04901d6e5cd2b92...1b844f0c5ac6446a402e0cb3693f9be5eca188c5) --- updated-dependencies: - dependency-name: actions/add-to-project dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/add-to-project.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/add-to-project.yml b/.github/workflows/add-to-project.yml index 61a140dccaaa..1d8151cfec3b 100644 --- a/.github/workflows/add-to-project.yml +++ b/.github/workflows/add-to-project.yml @@ -19,7 +19,7 @@ jobs: name: Add issue with enhancement label to the Proposals project runs-on: ubuntu-latest steps: - - uses: actions/add-to-project@0609a2702eefb44781da00f8e04901d6e5cd2b92 #v0.6.0 + - uses: actions/add-to-project@1b844f0c5ac6446a402e0cb3693f9be5eca188c5 #v0.6.1 with: labeled: ${{ env.LABEL_ENHANCEMENT }} project-url: ${{ env.PROPOSALS_PROJECT_URL }} @@ -29,7 +29,7 @@ jobs: name: Add issue with typescript label to the TypeScript Adoption project runs-on: ubuntu-latest steps: - - uses: actions/add-to-project@0609a2702eefb44781da00f8e04901d6e5cd2b92 #v0.6.0 + - uses: actions/add-to-project@1b844f0c5ac6446a402e0cb3693f9be5eca188c5 #v0.6.1 with: labeled: ${{ env.LABEL_TYPESCRIPT }} project-url: ${{ env.TYPESCRIPT_PROJECT_URL }} @@ -39,7 +39,7 @@ jobs: name: Add issue to the Design System project runs-on: ubuntu-latest steps: - - uses: actions/add-to-project@0609a2702eefb44781da00f8e04901d6e5cd2b92 #v0.6.0 + - uses: actions/add-to-project@1b844f0c5ac6446a402e0cb3693f9be5eca188c5 #v0.6.1 with: labeled: ${{ env.LABEL_ENHANCEMENT }}, ${{ env.LABEL_TYPESCRIPT }} label-operator: NOT From 41418ad00c1fdf3ab41e86a3b8e34f588ee6b538 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 26 Mar 2024 15:08:43 -0700 Subject: [PATCH 8/8] chore(deps): bump github/codeql-action from 3.24.8 to 3.24.9 (#16034) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.8 to 3.24.9. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/github/codeql-action/compare/05963f47d870e2cb19a537396c1f668a348c7d8f...1b1aada464948af03b950897e5eb522f92603cc2) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/codeql-analysis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml index 1cbc896b47f7..6be37a9f1387 100644 --- a/.github/workflows/codeql-analysis.yml +++ b/.github/workflows/codeql-analysis.yml @@ -24,9 +24,9 @@ jobs: # Initializes the CodeQL tools for scanning. - name: Initialize CodeQL - uses: github/codeql-action/init@05963f47d870e2cb19a537396c1f668a348c7d8f #v3.24.8 + uses: github/codeql-action/init@1b1aada464948af03b950897e5eb522f92603cc2 #v3.24.9 with: languages: javascript - name: Perform CodeQL Analysis - uses: github/codeql-action/analyze@05963f47d870e2cb19a537396c1f668a348c7d8f #v3.24.8 + uses: github/codeql-action/analyze@1b1aada464948af03b950897e5eb522f92603cc2 #v3.24.9