Skip to content

Commit

Permalink
feat(icons): renaming diamond status icon glyph (#12575)
Browse files Browse the repository at this point in the history
* feat(icons): renaming diamond status icon glyph

Old version of the icon was named "undefined" which was conflicting with another icon in the repo.

Renaming to "diamond-fill" to match the convention of other status glyph names and resolve the naming conflict.

Updated categories.yml file with new icon name.
Approved by Carbon and Brand team

* added diamond-fill to icons.yml file

added diamond-fill to icons.yml file and removed glyph sizing from undefined.svg icon

* chore: update snapshots

Co-authored-by: Alison Joseph <[email protected]>
Co-authored-by: TJ Egan <[email protected]>
Co-authored-by: Taylor Jones <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
  • Loading branch information
5 people authored Nov 15, 2022
1 parent 7650c77 commit 6d9f602
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 10 deletions.
1 change: 1 addition & 0 deletions e2e/icons-react/__snapshots__/PublicAPI-test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,7 @@ Array [
"DewPointFilled",
"Diagram",
"DiagramReference",
"DiamondFill",
"DirectLink",
"DirectionBearRight_01",
"DirectionBearRight_01Filled",
Expand Down
2 changes: 1 addition & 1 deletion e2e/icons-vue/__snapshots__/PublicAPI-test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -1993,6 +1993,7 @@ Array [
"DiagramReference20",
"DiagramReference24",
"DiagramReference32",
"DiamondFillGlyph",
"DirectLink16",
"DirectLink20",
"DirectLink24",
Expand Down Expand Up @@ -6924,7 +6925,6 @@ Array [
"UndefinedFilled20",
"UndefinedFilled24",
"UndefinedFilled32",
"UndefinedGlyph",
"Undo16",
"Undo20",
"Undo24",
Expand Down
2 changes: 1 addition & 1 deletion e2e/icons/__snapshots__/PublicAPI-test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -1992,6 +1992,7 @@ Array [
"DiagramReference20",
"DiagramReference24",
"DiagramReference32",
"DiamondFillGlyph",
"DirectLink16",
"DirectLink20",
"DirectLink24",
Expand Down Expand Up @@ -6923,7 +6924,6 @@ Array [
"UndefinedFilled20",
"UndefinedFilled24",
"UndefinedFilled32",
"UndefinedGlyph",
"Undo16",
"Undo20",
"Undo24",
Expand Down
15 changes: 8 additions & 7 deletions packages/icons/categories.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1316,26 +1316,26 @@ categories:
- ZIP--reference
- name: Status
members:
- caution
- caution-inverted
- checkmark
- checkmark--filled
- checkmark--filled--error
- checkmark--filled--warning
- checkmark--outline
- checkmark--outline--error
- checkmark--outline--warning
- circle-fill
- circle-stroke
- condition--point
- condition--wait-point
- critical
- critical-severity
- diamond-fill
- error
- error--filled
- error--outline
- caution
- caution-inverted
- circle-fill
- circle-stroke
- critical-severity
- low-severity
- critical
- square-fill
- help
- help--filled
- in-progress
Expand All @@ -1355,6 +1355,7 @@ categories:
- pending
- pending--filled
- queued
- square-fill
- undefined
- undefined--filled
- unknown
Expand Down
9 changes: 8 additions & 1 deletion packages/icons/icons.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5855,6 +5855,14 @@
- source
sizes:
- 32
- name: diamond-fill
friendly_name: Diamond fill
aliases:
- diamond
- fill
- status
sizes:
- glyph
- name: dicom--6000
friendly_name: DICOM 6000
sizes:
Expand Down Expand Up @@ -18463,7 +18471,6 @@
- undefined
sizes:
- 32
- glyph
- name: undefined--filled
friendly_name: Undefined filled
sizes:
Expand Down
File renamed without changes

0 comments on commit 6d9f602

Please sign in to comment.