Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(styles): update placeholder colors (#4799)
Browse files Browse the repository at this point in the history
This change updates placeholder color of some components from
`$text-03` to e.g. `$text-05` to meet the color contrast requirement.

This change also replaces manual usage of colors in style rules with
the Sass mixin for placeholder `@include placeholder-colors`.

Fixes #4231.
asudoh authored and joshblack committed Jan 6, 2020
1 parent f6f989d commit 69d495a
Showing 4 changed files with 7 additions and 4 deletions.
3 changes: 1 addition & 2 deletions packages/components/src/components/combo-box/_combo-box.scss
Original file line number Diff line number Diff line change
@@ -19,8 +19,7 @@
@mixin combo-box {
.#{$prefix}--combo-box .#{$prefix}--text-input {
&::placeholder {
color: $text-02;
opacity: 1;
color: $text-05;
}

&[disabled]::placeholder {
Original file line number Diff line number Diff line change
@@ -120,7 +120,7 @@
}

&::placeholder {
@include placeholder-colors;
color: $text-05;
opacity: 1;
}
}
Original file line number Diff line number Diff line change
@@ -61,7 +61,7 @@
}

.#{$prefix}--text-area::placeholder {
color: $text-05;
@include placeholder-colors;
@include type-style('body-long-01');
opacity: 1;
}
Original file line number Diff line number Diff line change
@@ -58,6 +58,10 @@
height: rem(40px);
transition: outline $duration--fast-01 motion(standard, productive),
background-color $duration--fast-01 motion(standard, productive);

&::placeholder {
color: $text-05;
}
}
}

0 comments on commit 69d495a

Please sign in to comment.