Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[data viz color palette]: light and dark theme palettes are not switching #1936

Closed
jeanservaas opened this issue Oct 29, 2020 · 2 comments

Comments

@jeanservaas
Copy link
Collaborator

In the pairings switcher, the when users toggle between Light and Dark tabs, the palettes do not change.

The component is displaying the dark theme palette under the Light tab as well as the Dark tab, whereas it should display the Light theme palette when the user selects the Light tab:

image

image

The same error is happening with the Alert palette switcher, only the light theme palette is showing for both the Light and Dark tabs :

image

image

@mjabbink
Copy link
Contributor

@alisonjoseph This needs to be prioritized big time. Not understanding why this is not resolved in 25 days. @jeanservaas and @alisonjoseph please keep me posted on issue. Needs to be closed next week please.

@tw15egan
Copy link
Collaborator

@mjabbink pr is up to fix the grouped color palettes, but it looks like there is only 1 palette for alerts across both themes

export const alert = [
{
name: 'Red 60',
hex: 'da1e28',
light: true,
},
{
name: 'Orange 40',
hex: 'ff832b',
light: false,
},
{
name: 'Green 50',
hex: '24a148',
light: false,
},
{
name: 'Yellow 30',
hex: 'f1c21b',
light: false,
},
];

@jeanservaas is this incorrect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants