Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic support for other libraries #20

Closed
benmccann opened this issue Oct 16, 2021 · 2 comments
Closed

Generic support for other libraries #20

benmccann opened this issue Oct 16, 2021 · 2 comments

Comments

@benmccann
Copy link

I ran into the same problem this preprocessor is solving in another library and was just pointed here. Wow. This is a pretty ingenious solution! I couldn't come up with any answer I liked myself

I think it could be recommended for all projects in the SvelteKit FAQ. Possibly it could even be included in SvelteKit by default until / unless another solution is built in

I was wondering, is there anything Carbon-specific about it? Maybe it could be called something more general like carbon-design-system/fast-imports-preprocessor?

@metonym
Copy link
Collaborator

metonym commented Oct 16, 2021

@benmccann I would love to see this be supported by SvelteKit!

I was wondering, is there anything Carbon-specific about it?

Definitely nothing Carbon-specific, but as @dominikg alluded to, a generic approach would probably require some runtime logic.

This preprocessor creates and consumes a pre-built file that maps the Carbon component to the actual source path.

@benmccann
Copy link
Author

I'm going to close this since a feature has been added to vite-plugin-svelte that removes the need for it: sveltejs/vite-plugin-svelte#200

If that feature doesn't work out as a solution, maybe I'll be back here 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants