Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(toc): add an event to trigger harvesting of anchor tags #8329

Merged
merged 1 commit into from
Feb 18, 2022
Merged

feat(toc): add an event to trigger harvesting of anchor tags #8329

merged 1 commit into from
Feb 18, 2022

Conversation

proeung
Copy link
Contributor

@proeung proeung commented Feb 17, 2022

Related Ticket(s)

#8216

Description

  • This PR exposes an event that triggers the harvesting of anchor tags within the Table of Contents component.
  • This feature allows AEM CMS Content Authors to see their inline text changes reflected in the anchor tags area of the Table of Contents.

Changelog

New

  • dds-table-of-contents-reharvest custom event.
Screen.Recording.2022-02-17.at.11.14.57.AM.mov

@proeung proeung added package: web components Work necessary for the IBM.com Library web components package adopter: AEM used when component or pattern will be used by this adopter 👀 eyes needed labels Feb 17, 2022
@proeung proeung requested a review from a team as a code owner February 17, 2022 16:19
@proeung proeung mentioned this pull request Feb 17, 2022
Closed
2 tasks
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/8329/index.html

Built with commit: 3d08efd7e7259b7846d37e0164977ade8615904a

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8329/index.html

Built with commit: 3d08efd7e7259b7846d37e0164977ade8615904a

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8329/index.html

Built with commit: 3d08efd7e7259b7846d37e0164977ade8615904a

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8329/index.html

Built with commit: 3d08efd7e7259b7846d37e0164977ade8615904a

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8329/index.html

Built with commit: 3d08efd7e7259b7846d37e0164977ade8615904a

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8329/index.html

Built with commit: 3d08efd7e7259b7846d37e0164977ade8615904a

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8329/index.html

Built with commit: 3d08efd7e7259b7846d37e0164977ade8615904a

IgnacioBecerra
IgnacioBecerra approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @proeung!

@dratzenboeck-ibm
Copy link

LGTM

@proeung proeung added Ready to merge Label for the pull requests that are ready to merge and removed 👀 eyes needed labels Feb 18, 2022
@kodiakhq kodiakhq bot merged commit 4c2540b into carbon-design-system:main Feb 18, 2022
@proeung proeung linked an issue Feb 18, 2022 that may be closed by this pull request
[Table of Contents]: Manual trigger for anchor harvesting - DPO Consulting #8216
Closed
2 tasks
@IgnacioBecerra IgnacioBecerra mentioned this pull request Feb 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnacioBecerra IgnacioBecerra IgnacioBecerra approved these changes

@RichKummer RichKummer Awaiting requested review from RichKummer RichKummer is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
adopter: AEM used when component or pattern will be used by this adopter package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Table of Contents]: Manual trigger for anchor harvesting - DPO Consulting
4 participants
@proeung @ibmdotcom-bot @dratzenboeck-ibm @IgnacioBecerra