Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): update Web Components version to 1.x #4939

Merged

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Jan 20, 2021

Description

Updates version field of Web Components' package.json to 1.x as we release Web Components package as GA as of v1.15.0.

Changelog

Changed

  • The version field of packages/web-components/package.json.

Updates `version` field of Web Components' `package.json` to `1.x` as
we release Web Components package as GA as of `v1.15.0`.
@asudoh asudoh added the package: web components Work necessary for the IBM.com Library web components package label Jan 20, 2021
@asudoh asudoh requested a review from jeffchew January 20, 2021 08:59
@asudoh asudoh changed the base branch from master to release/v1.15.0 January 20, 2021 08:59
@asudoh
Copy link
Contributor Author

asudoh commented Jan 20, 2021

@jeffchew Do we need to update any release script for this? Thanks!

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 20, 2021

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 20, 2021

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 20, 2021

@@ -1,6 +1,6 @@
{
"name": "@carbon/ibmdotcom-web-components",
"version": "0.8.0-rc.0",
"version": "1.15.0-rc.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating @asudoh!

We should actually bump to 1.0.0-rc.0, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah wondering which was better, will update. Thanks @jeffchew for your feedback!

Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @asudoh !

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Jan 20, 2021
@kodiakhq kodiakhq bot merged commit 9d1c4d7 into carbon-design-system:release/v1.15.0 Jan 20, 2021
@asudoh asudoh deleted the web-components-version branch January 20, 2021 15:37
IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this pull request Feb 22, 2021
…ystem#4939)

### Description

Updates `version` field of Web Components' `package.json` to `1.x` as we release Web Components package as GA as of `v1.15.0`.

### Changelog

**Changed**

- The `version` field of `packages/web-components/package.json`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants