Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(devenv): make pictograms themeable #4729

Merged
merged 2 commits into from
Dec 15, 2020

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Dec 15, 2020

Related Ticket(s)

Refs #4594.

Description

Fixed an issue in the story implementation for <dds-content-group-pictograms> that had inline <style> for the stroke color.

Changelog

Changed

  • Replaced the line <style> for the pictogram's stroke color with a CSS rule referring to Carbon color token.

Fixed an issue in the story implementation for
`<dds-content-group-pictograms>` that had inline `<style>` for the
stroke color.

Refs carbon-design-system#4594.
@asudoh asudoh added the package: web components Work necessary for the IBM.com Library web components package label Dec 15, 2020
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 15, 2020

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 15, 2020

Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @asudoh!

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Dec 15, 2020
@kodiakhq kodiakhq bot merged commit 78e653c into carbon-design-system:master Dec 15, 2020
@asudoh asudoh deleted the pictograms-theme branch December 15, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants