feat(web-components): add React wrapper #4678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds React wrapper generator (`createReactCustomElementType`), based on one in `carbon-web-components` to `@carbon/ibmdotcom-web-components` codebase. It helps our adoptors using React to use our components, with the following support that React itself lacks for non-intrinsic elements: * Element attributes mapping to non-string element property values (e.g. Boolean attributes) * React props mapping to element properties instead of element attributes * Event handlers Also adds a Babel plugin that automatically creates React wrappers of our components from our components' `@property()` annotations, as well as the corresponding build process that generates the React wrappers to `es/components-react` directory. So in the most typical scenario, our users can use components in `es/components-react` directory in the same manner as regular React components. Also adds React stories so we can demonstrate the React integration. Refs carbon-design-system#4251.
asudoh
added
package: react
|
Deploy preview created for package Built with commit: 4fcd9df2a291c48c2d1811ba6c82b2e934bf4158 |
|
Deploy preview created for package Built with commit: 4fcd9df2a291c48c2d1811ba6c82b2e934bf4158 |
asudoh
force-pushed
the
react-ssr-partial
branch
4 times, most recently
from
19b16a2 to
cd79f66
Compare
asudoh
force-pushed
the
react-ssr-partial
branch
from
cd79f66 to
368e7f7
Compare
kennylam
approved these changes
Dec 15, 2020
|
Thank you @asudoh ! Can you resolve the conflicts? |
jeffchew
added
the
Ready to merge
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
kodiakhq
bot
removed
the
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Refs #4251.
Description
Adds React wrapper generator (
createReactCustomElementType), based on one incarbon-web-componentsto@carbon/ibmdotcom-web-componentscodebase.It helps our adaptors using React to use our components, with the following support that React itself lacks for non-intrinsic elements:
Also adds a Babel plugin that automatically creates React wrappers of our components from our components'
@property()annotations, as well as the corresponding build process that generates the React wrappers toes/components-reactdirectory. So in the most typical scenario, our users can use components ines/components-reactdirectory in the samemanner as regular React components.
Also adds React stories so we can demonstrate the React integration.
Changelog
New
createReactCustomElementType).Changed
defs.tsto make above build steps simpler.