From bba634d2489f960afd44b08d95b20df889f9ec35 Mon Sep 17 00:00:00 2001 From: Sangeetha Babu <58620134+sangeethababu9223@users.noreply.github.com> Date: Fri, 8 Sep 2023 13:02:42 +0530 Subject: [PATCH 01/15] feat(leaving-ibm): style issue fix --- .../src/components/modal/modal.scss | 10 +- packages/react/stats.html | 3293 +++++++++++++++++ .../components/leaving-ibm/leaving-ibm.scss | 6 +- 3 files changed, 3305 insertions(+), 4 deletions(-) create mode 100644 packages/react/stats.html diff --git a/packages/carbon-web-components/src/components/modal/modal.scss b/packages/carbon-web-components/src/components/modal/modal.scss index db14a7a613f..311a1ea3095 100644 --- a/packages/carbon-web-components/src/components/modal/modal.scss +++ b/packages/carbon-web-components/src/components/modal/modal.scss @@ -18,7 +18,15 @@ :host(#{$prefix}-modal[open]) { @extend .#{$prefix}--modal; - @extend .is-visible; + // @extend .is-visible; + opacity: 1; + transition: opacity $duration-moderate-02 motion(entrance, expressive), + visibility 0ms linear; + visibility: inherit; + + @media screen and (prefers-reduced-motion: reduce) { + transition: none; + } } :host(#{$prefix}-modal) { diff --git a/packages/react/stats.html b/packages/react/stats.html new file mode 100644 index 00000000000..17f22f5ab58 --- /dev/null +++ b/packages/react/stats.html @@ -0,0 +1,3293 @@ + + + + + + + RollUp Visualizer + + + + +
+

RollUp Visualizer

+
+
+ + + + + + diff --git a/packages/web-components/src/components/leaving-ibm/leaving-ibm.scss b/packages/web-components/src/components/leaving-ibm/leaving-ibm.scss index 1cccd1dc975..db85833d008 100644 --- a/packages/web-components/src/components/leaving-ibm/leaving-ibm.scss +++ b/packages/web-components/src/components/leaving-ibm/leaving-ibm.scss @@ -18,11 +18,11 @@ } :host(#{$c4d-prefix}-leaving-ibm-modal) { - // @extend :host(#{$prefix}-modal); + @extend :host(#{$prefix}-modal); max-height: 100%; &[open] { - // @extend :host(#{$prefix}-modal[open]); + @extend :host(#{$prefix}-modal[open]); } } @@ -31,7 +31,7 @@ } :host(#{$c4d-prefix}-leaving-ibm-modal-body) { - // @extend :host(#{$prefix}-modal-body); + @extend :host(#{$prefix}-modal-body); padding-right: 20%; ::slotted(#{$c4d-prefix}-leaving-ibm-modal-supplemental), From adb34c4775196bde1ac911fadff1a91475167da1 Mon Sep 17 00:00:00 2001 From: Sangeetha Babu <58620134+sangeethababu9223@users.noreply.github.com> Date: Thu, 14 Sep 2023 17:33:54 +0530 Subject: [PATCH 02/15] feat(leaving-ibm): update to v2 --- .../web-components/src/components/leaving-ibm/leaving-ibm.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/web-components/src/components/leaving-ibm/leaving-ibm.scss b/packages/web-components/src/components/leaving-ibm/leaving-ibm.scss index db85833d008..3ad5c9245da 100644 --- a/packages/web-components/src/components/leaving-ibm/leaving-ibm.scss +++ b/packages/web-components/src/components/leaving-ibm/leaving-ibm.scss @@ -27,7 +27,7 @@ } :host(#{$c4d-prefix}-leaving-ibm-modal-heading) { - // @include type-style('fluid-heading-04'); + @include type-style('fluid-heading-04'); } :host(#{$c4d-prefix}-leaving-ibm-modal-body) { From bcb81a4a3dab0bc524a2f4d7b07d2f97ebbc8e04 Mon Sep 17 00:00:00 2001 From: Sangeetha Babu <58620134+sangeethababu9223@users.noreply.github.com> Date: Thu, 14 Sep 2023 18:01:16 +0530 Subject: [PATCH 03/15] feat(leaving-ibm): update to v2 --- .../src/components/leaving-ibm/leaving-ibm-composite.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/web-components/src/components/leaving-ibm/leaving-ibm-composite.ts b/packages/web-components/src/components/leaving-ibm/leaving-ibm-composite.ts index a720b0ee510..01780eabf94 100644 --- a/packages/web-components/src/components/leaving-ibm/leaving-ibm-composite.ts +++ b/packages/web-components/src/components/leaving-ibm/leaving-ibm-composite.ts @@ -157,9 +157,13 @@ class C4DLeavingIbmComposite extends HostListenerMixin( ${leavingIbmButtonLabel} + + ${leavingIbmButtonLabel} + + From b399ea1bbbf14bc347314ea8227201297f876036 Mon Sep 17 00:00:00 2001 From: Sangeetha Babu <58620134+sangeethababu9223@users.noreply.github.com> Date: Fri, 15 Sep 2023 11:23:16 +0530 Subject: [PATCH 04/15] feat(leaving-ibm) : v2 style updates --- .../components/leaving-ibm/leaving-ibm-composite.ts | 10 +++------- .../src/components/leaving-ibm/leaving-ibm.scss | 2 ++ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/packages/web-components/src/components/leaving-ibm/leaving-ibm-composite.ts b/packages/web-components/src/components/leaving-ibm/leaving-ibm-composite.ts index 01780eabf94..ca17e5763f0 100644 --- a/packages/web-components/src/components/leaving-ibm/leaving-ibm-composite.ts +++ b/packages/web-components/src/components/leaving-ibm/leaving-ibm-composite.ts @@ -155,15 +155,11 @@ class C4DLeavingIbmComposite extends HostListenerMixin( > - - - ${leavingIbmButtonLabel} - - ${leavingIbmButtonLabel} diff --git a/packages/web-components/src/components/leaving-ibm/leaving-ibm.scss b/packages/web-components/src/components/leaving-ibm/leaving-ibm.scss index 3ad5c9245da..3f5b7f576b3 100644 --- a/packages/web-components/src/components/leaving-ibm/leaving-ibm.scss +++ b/packages/web-components/src/components/leaving-ibm/leaving-ibm.scss @@ -39,10 +39,12 @@ display: block; margin-top: $spacing-07; color: $text-secondary; + padding-bottom: 0 !important; @include type-style('label-02'); } > p { padding-right: 0; + margin: 0; } } From 165e20353bfc5cb4d27b089d375b36dd3f869f9a Mon Sep 17 00:00:00 2001 From: Sangeetha Babu <58620134+sangeethababu9223@users.noreply.github.com> Date: Mon, 18 Sep 2023 12:31:52 +0530 Subject: [PATCH 05/15] feat(leaving-ibm): haedline style fix --- packages/react/stats.html | 3293 ----------------- .../components/leaving-ibm/leaving-ibm.scss | 2 +- 2 files changed, 1 insertion(+), 3294 deletions(-) delete mode 100644 packages/react/stats.html diff --git a/packages/react/stats.html b/packages/react/stats.html deleted file mode 100644 index 17f22f5ab58..00000000000 --- a/packages/react/stats.html +++ /dev/null @@ -1,3293 +0,0 @@ - - - - - - - RollUp Visualizer - - - - -
-

RollUp Visualizer

-
-
- - - - - - diff --git a/packages/web-components/src/components/leaving-ibm/leaving-ibm.scss b/packages/web-components/src/components/leaving-ibm/leaving-ibm.scss index 3f5b7f576b3..cc0ec3585ca 100644 --- a/packages/web-components/src/components/leaving-ibm/leaving-ibm.scss +++ b/packages/web-components/src/components/leaving-ibm/leaving-ibm.scss @@ -27,7 +27,7 @@ } :host(#{$c4d-prefix}-leaving-ibm-modal-heading) { - @include type-style('fluid-heading-04'); + @include type-style('fluid-heading-04', true); } :host(#{$c4d-prefix}-leaving-ibm-modal-body) { From 085dda0a605637fdc2863f9936426f357467f336 Mon Sep 17 00:00:00 2001 From: Sangeetha Babu <58620134+sangeethababu9223@users.noreply.github.com> Date: Mon, 18 Sep 2023 16:44:00 +0530 Subject: [PATCH 06/15] feat(leaving-ibm): style fix --- .../scss/components/leaving-ibm/_index.scss | 11 ++++ .../components/leaving-ibm/_leaving-ibm.scss | 52 +++++++++++++++++++ .../components/leaving-ibm/leaving-ibm.scss | 44 +--------------- 3 files changed, 64 insertions(+), 43 deletions(-) create mode 100644 packages/styles/scss/components/leaving-ibm/_index.scss create mode 100644 packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss diff --git a/packages/styles/scss/components/leaving-ibm/_index.scss b/packages/styles/scss/components/leaving-ibm/_index.scss new file mode 100644 index 00000000000..6f41a6978c2 --- /dev/null +++ b/packages/styles/scss/components/leaving-ibm/_index.scss @@ -0,0 +1,11 @@ +// +// Copyright IBM Corp. 2018, 2023 +// +// This source code is licensed under the Apache-2.0 license found in the +// LICENSE file in the root directory of this source tree. +// + +@forward 'leaving-ibm'; +@use 'leaving-ibm'; + +@include leaving-ibm.leaving-ibm; diff --git a/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss b/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss new file mode 100644 index 00000000000..427863add8a --- /dev/null +++ b/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss @@ -0,0 +1,52 @@ +// +// Copyright IBM Corp. 2020, 2023 +// +// This source code is licensed under the Apache-2.0 license found in the +// LICENSE file in the root directory of this source tree. +// + +@use '@carbon/styles/scss/config' as *; +@use '@carbon/styles/scss/spacing' as *; +@use '@carbon/styles/scss/theme' as *; +@use '@carbon/styles/scss/type' as *; +@use '../../../../carbon-web-components/src/components/modal/modal' as *; +@use '@carbon/ibmdotcom-styles/scss/globals/vars' as *; + +@mixin leaving-ibm { + :host(#{$c4d-prefix}-leaving-ibm-composite), + :host(#{$c4d-prefix}-leaving-ibm-container) { + width: 100%; + } + + :host(#{$c4d-prefix}-leaving-ibm-modal) { + @extend :host(#{$prefix}-modal); + max-height: 100%; + + &[open] { + @extend :host(#{$prefix}-modal[open]); + } + } + + :host(#{$c4d-prefix}-leaving-ibm-modal-heading) { + @include type-style('fluid-heading-04', true); + } + + :host(#{$c4d-prefix}-leaving-ibm-modal-body) { + @extend :host(#{$prefix}-modal-body); + padding-right: 20%; + + ::slotted(#{$c4d-prefix}-leaving-ibm-modal-supplemental), + ::slotted(slot[name='supplemental']) { + display: block; + margin-top: $spacing-07; + color: $text-secondary; + padding-bottom: 0 !important; + @include type-style('label-02'); + } + + > p { + padding-right: 0; + margin: 0; + } + } +} diff --git a/packages/web-components/src/components/leaving-ibm/leaving-ibm.scss b/packages/web-components/src/components/leaving-ibm/leaving-ibm.scss index cc0ec3585ca..0a852af8de0 100644 --- a/packages/web-components/src/components/leaving-ibm/leaving-ibm.scss +++ b/packages/web-components/src/components/leaving-ibm/leaving-ibm.scss @@ -5,46 +5,4 @@ // LICENSE file in the root directory of this source tree. // -@use '@carbon/styles/scss/config' as *; -@use '@carbon/styles/scss/spacing' as *; -@use '@carbon/styles/scss/theme' as *; -@use '@carbon/styles/scss/type' as *; -@use '../../../../carbon-web-components/src/components/modal/modal'; -@use '@carbon/ibmdotcom-styles/scss/globals/vars' as *; - -:host(#{$c4d-prefix}-leaving-ibm-composite), -:host(#{$c4d-prefix}-leaving-ibm-container) { - width: 100%; -} - -:host(#{$c4d-prefix}-leaving-ibm-modal) { - @extend :host(#{$prefix}-modal); - max-height: 100%; - - &[open] { - @extend :host(#{$prefix}-modal[open]); - } -} - -:host(#{$c4d-prefix}-leaving-ibm-modal-heading) { - @include type-style('fluid-heading-04', true); -} - -:host(#{$c4d-prefix}-leaving-ibm-modal-body) { - @extend :host(#{$prefix}-modal-body); - padding-right: 20%; - - ::slotted(#{$c4d-prefix}-leaving-ibm-modal-supplemental), - ::slotted(slot[name='supplemental']) { - display: block; - margin-top: $spacing-07; - color: $text-secondary; - padding-bottom: 0 !important; - @include type-style('label-02'); - } - - > p { - padding-right: 0; - margin: 0; - } -} +@use '@carbon/ibmdotcom-styles/scss/components/leaving-ibm'; From 711d4dd8b9664d3813b4d5c938abe67fe35d2f75 Mon Sep 17 00:00:00 2001 From: Sangeetha Babu <58620134+sangeethababu9223@users.noreply.github.com> Date: Mon, 18 Sep 2023 21:49:35 +0530 Subject: [PATCH 07/15] feat(leaving-ibm): scss lint fix --- .../styles/scss/components/leaving-ibm/_leaving-ibm.scss | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss b/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss index 427863add8a..d7fd35d4219 100644 --- a/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss +++ b/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss @@ -20,6 +20,7 @@ :host(#{$c4d-prefix}-leaving-ibm-modal) { @extend :host(#{$prefix}-modal); + max-height: 100%; &[open] { @@ -33,6 +34,7 @@ :host(#{$c4d-prefix}-leaving-ibm-modal-body) { @extend :host(#{$prefix}-modal-body); + padding-right: 20%; ::slotted(#{$c4d-prefix}-leaving-ibm-modal-supplemental), @@ -40,7 +42,6 @@ display: block; margin-top: $spacing-07; color: $text-secondary; - padding-bottom: 0 !important; @include type-style('label-02'); } @@ -49,4 +50,7 @@ margin: 0; } } + :host(c4d-leaving-ibm-modal-body) ::slotted(:last-child) { + padding-bottom: 0 !important; + } } From 136ac94d643257caabfade161594f2cbefc3ed1b Mon Sep 17 00:00:00 2001 From: Sangeetha Babu <58620134+sangeethababu9223@users.noreply.github.com> Date: Mon, 18 Sep 2023 22:01:11 +0530 Subject: [PATCH 08/15] feat(leaving-ibm): scss fix --- packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss b/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss index d7fd35d4219..09d83953a25 100644 --- a/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss +++ b/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss @@ -51,6 +51,6 @@ } } :host(c4d-leaving-ibm-modal-body) ::slotted(:last-child) { - padding-bottom: 0 !important; + padding-bottom: 0 !important; } } From c3916e82d01e0f26df3badc0fbc57e668cd64557 Mon Sep 17 00:00:00 2001 From: Sangeetha Babu <58620134+sangeethababu9223@users.noreply.github.com> Date: Mon, 18 Sep 2023 22:21:43 +0530 Subject: [PATCH 09/15] feat(leaving-ibm) fix scss issue --- .../styles/scss/components/leaving-ibm/_leaving-ibm.scss | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss b/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss index 09d83953a25..a24142d338f 100644 --- a/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss +++ b/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss @@ -49,8 +49,8 @@ padding-right: 0; margin: 0; } - } - :host(c4d-leaving-ibm-modal-body) ::slotted(:last-child) { - padding-bottom: 0 !important; + ::slotted(:last-child) { + padding-bottom: 0; + } } } From 768b522895b2e910c61e7bc11e44e5e68bf2d088 Mon Sep 17 00:00:00 2001 From: Sangeetha Babu <58620134+sangeethababu9223@users.noreply.github.com> Date: Wed, 20 Sep 2023 11:00:37 +0530 Subject: [PATCH 10/15] feat(leaving-ibm): code review update --- .../carbon-web-components/src/components/modal/modal.scss | 1 - .../styles/scss/components/leaving-ibm/_leaving-ibm.scss | 7 +++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/carbon-web-components/src/components/modal/modal.scss b/packages/carbon-web-components/src/components/modal/modal.scss index 311a1ea3095..16d57b40ae2 100644 --- a/packages/carbon-web-components/src/components/modal/modal.scss +++ b/packages/carbon-web-components/src/components/modal/modal.scss @@ -18,7 +18,6 @@ :host(#{$prefix}-modal[open]) { @extend .#{$prefix}--modal; - // @extend .is-visible; opacity: 1; transition: opacity $duration-moderate-02 motion(entrance, expressive), visibility 0ms linear; diff --git a/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss b/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss index a24142d338f..fe1b9c84e79 100644 --- a/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss +++ b/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss @@ -22,10 +22,9 @@ @extend :host(#{$prefix}-modal); max-height: 100%; - - &[open] { - @extend :host(#{$prefix}-modal[open]); - } + } + :host(#{$c4d-prefix}-leaving-ibm-modal)[open] { + @extend :host(#{$prefix}-modal[open]); } :host(#{$c4d-prefix}-leaving-ibm-modal-heading) { From 8bba44f3021f2583ed1509d1cc7f5b732a990bd1 Mon Sep 17 00:00:00 2001 From: Sangeetha Babu <58620134+sangeethababu9223@users.noreply.github.com> Date: Thu, 21 Sep 2023 15:33:37 +0530 Subject: [PATCH 11/15] feat(leaving-ibm): design review fixes --- .../styles/scss/components/leaving-ibm/_leaving-ibm.scss | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss b/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss index fe1b9c84e79..8bfda181f0e 100644 --- a/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss +++ b/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss @@ -35,6 +35,7 @@ @extend :host(#{$prefix}-modal-body); padding-right: 20%; + z-index: 1; ::slotted(#{$c4d-prefix}-leaving-ibm-modal-supplemental), ::slotted(slot[name='supplemental']) { @@ -52,4 +53,7 @@ padding-bottom: 0; } } -} + .#{$prefix}--modal-container { + transform: translate3d(0px, 0px, 0px); + } +} \ No newline at end of file From 89043db8f3a614d28fd16c8d7c25292e4ce05a43 Mon Sep 17 00:00:00 2001 From: Sangeetha Babu <58620134+sangeethababu9223@users.noreply.github.com> Date: Thu, 21 Sep 2023 20:22:30 +0530 Subject: [PATCH 12/15] feat(leaving-ibm): style format --- .../components/callout-with-media/_callout-with-media.scss | 3 ++- packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/styles/scss/components/callout-with-media/_callout-with-media.scss b/packages/styles/scss/components/callout-with-media/_callout-with-media.scss index 54ab0ecec35..6b579fdaaf1 100644 --- a/packages/styles/scss/components/callout-with-media/_callout-with-media.scss +++ b/packages/styles/scss/components/callout-with-media/_callout-with-media.scss @@ -91,7 +91,8 @@ @extend :host(#{$c4d-prefix}-callout-text[color-scheme='cyan']); } - :host(#{$c4d-prefix}-callout-with-media-image) .#{$c4d-prefix}--image__caption, + :host(#{$c4d-prefix}-callout-with-media-image) + .#{$c4d-prefix}--image__caption, :host(#{$c4d-prefix}-callout-with-media-video) ::slotted(#{$c4d-prefix}-video-player) { @extend :host(#{$c4d-prefix}-callout-caption); diff --git a/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss b/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss index 8bfda181f0e..aadcd90d9c4 100644 --- a/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss +++ b/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss @@ -56,4 +56,4 @@ .#{$prefix}--modal-container { transform: translate3d(0px, 0px, 0px); } -} \ No newline at end of file +} From cea82459a824ef833b9b6b0a1d8570a25cd7a144 Mon Sep 17 00:00:00 2001 From: Sangeetha Babu <58620134+sangeethababu9223@users.noreply.github.com> Date: Fri, 22 Sep 2023 20:43:28 +0530 Subject: [PATCH 13/15] feat(leaving-ibm): style review fix --- .../scss/components/leaving-ibm/_leaving-ibm.scss | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss b/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss index aadcd90d9c4..599598d99a0 100644 --- a/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss +++ b/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss @@ -22,6 +22,12 @@ @extend :host(#{$prefix}-modal); max-height: 100%; + // ::slotted(#{$c4d-prefix}-leaving-ibm-modal-body) { + // :host(#{$prefix}-link) { + // min-height: 23px; + // display: inline-block; + // } + // } } :host(#{$c4d-prefix}-leaving-ibm-modal)[open] { @extend :host(#{$prefix}-modal[open]); @@ -52,6 +58,10 @@ ::slotted(:last-child) { padding-bottom: 0; } + #{$prefix}-link { + min-height: 24px; + display: inline-block; + } } .#{$prefix}--modal-container { transform: translate3d(0px, 0px, 0px); From 2162678a51deceeadb35a8b1d78480b869746aa0 Mon Sep 17 00:00:00 2001 From: Sangeetha Babu <58620134+sangeethababu9223@users.noreply.github.com> Date: Mon, 25 Sep 2023 10:16:31 +0530 Subject: [PATCH 14/15] feat(leaving-ibm): review updates --- .../styles/scss/components/leaving-ibm/_leaving-ibm.scss | 6 ------ 1 file changed, 6 deletions(-) diff --git a/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss b/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss index 599598d99a0..4a2151b30e4 100644 --- a/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss +++ b/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss @@ -22,12 +22,6 @@ @extend :host(#{$prefix}-modal); max-height: 100%; - // ::slotted(#{$c4d-prefix}-leaving-ibm-modal-body) { - // :host(#{$prefix}-link) { - // min-height: 23px; - // display: inline-block; - // } - // } } :host(#{$c4d-prefix}-leaving-ibm-modal)[open] { @extend :host(#{$prefix}-modal[open]); From e9153acb5b136d5697d897098190bb29e33fdd8a Mon Sep 17 00:00:00 2001 From: Sangeetha Babu <58620134+sangeethababu9223@users.noreply.github.com> Date: Mon, 25 Sep 2023 15:10:24 +0530 Subject: [PATCH 15/15] feat(leaving-ibm): review updates --- packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss b/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss index 4a2151b30e4..c5f618520e2 100644 --- a/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss +++ b/packages/styles/scss/components/leaving-ibm/_leaving-ibm.scss @@ -58,6 +58,6 @@ } } .#{$prefix}--modal-container { - transform: translate3d(0px, 0px, 0px); + transform: translate3d(0, 0, 0); } }