Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components with input element activating Storybook shortcuts #9774

Closed
2 tasks done
IgnacioBecerra opened this issue Oct 29, 2021 · 1 comment
Closed
2 tasks done

Components with input element activating Storybook shortcuts #9774

IgnacioBecerra opened this issue Oct 29, 2021 · 1 comment
Labels
bug Something isn't working dev Needs some dev work inactive severity 4 Affects minor functionality, no workaround needed storybook

Comments

@IgnacioBecerra
Copy link
Contributor

IgnacioBecerra commented Oct 29, 2021

Description

As seen in carbon-design-system/carbon-web-components#717, some components are able to ignore the Storybook keyboard shortcuts while typing on an input bar, while others do not. For example, typing a 1 in a BXSearch will result in the components list to be focused, or typing an a will toggle the knob menu, while these actions don't happen when using BXInput.

It's a strange bug since it still occurs after stripping down the components to their bare minimum by only using an input element within their Shadow DOM (as seen in the PR linked), even though that they are the exact same component, only with a different name.

Video showing issue:
https://user-images.githubusercontent.com/24970122/139461104-893daaa3-34a2-48b7-8ec1-2729eabe2ed8.mov

Component(s) impacted

The components currently affected with this bug are:

  • BXSearch
  • BXCombobox
  • BXMultiSelect - filterable

Browser

No response

Carbon Web Components version

canary

Severity

Severity 4 = The problem is not visible to or noticeable to an average user. Affects minor functionality, no workaround needed.

Application/website

N/A

CodeSandbox example

carbon-design-system/carbon-web-components#717

Steps to reproduce the issue (if applicable)

Visit the search or combobox story and begin typing. If the key corresponds to a Storybook shortcut (e.g. a, d, f, s, t, 1) observe that the Storybook changes and focus can be stolen from the component being interacted with

Release date (if applicable)

No response

Code of Conduct

@IgnacioBecerra IgnacioBecerra added the bug Something isn't working label Oct 29, 2021
@RobertaJHahn RobertaJHahn added dev Needs some dev work storybook severity 4 Affects minor functionality, no workaround needed labels Nov 2, 2021
@kennylam kennylam transferred this issue from carbon-design-system/carbon-web-components Dec 6, 2022
@stale
Copy link

stale bot commented May 27, 2023

We've marked this issue as stale because there hasn't been any activity for 60 days. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label May 27, 2023
@andy-blum andy-blum closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev Needs some dev work inactive severity 4 Affects minor functionality, no workaround needed storybook
Projects
Status: Done
Development

No branches or pull requests

3 participants