Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Content block cards] Lightbox overlay with video spacing #8279

Closed
2 tasks done
RichKummer opened this issue Feb 15, 2022 · 2 comments
Closed
2 tasks done

[Content block cards] Lightbox overlay with video spacing #8279

RichKummer opened this issue Feb 15, 2022 · 2 comments
Labels
bug Something isn't working dev Needs some dev work hacktoberfest inactive package: react Work necessary for the Carbon for IBM.com react components package severity 3 Affects minor functionality, has a workaround

Comments

@RichKummer
Copy link

RichKummer commented Feb 15, 2022

Description

There is no spacing between the video in the lightbox overlay triggered by Content block cards. Compare between the React build and Web components. This bug is present on RTL version as well, and seeing it on Chrome.

React
Screen Shot 2022-02-15 at 9 55 10 AM

Web components
Screen Shot 2022-02-15 at 9 55 02 AM

Component(s) impacted

Content block cards - with videos

Browser

Firefox

Carbon for IBM.com version

v1.31.0-rc.1

Severity

Severity 3 = The problem is visible or noticeable to users but does not impede the usability or functionality. Affects minor functionality, has a workaround.

Application/website

C4IBM.com

Package

@carbon/ibmdotcom-react

CodeSandbox example

https://codesandbox.io/s/github/carbon-design-system/carbon-for-ibm-dotcom/tree/main/packages/react/examples/codesandbox/components/LightboxMediaViewer

Steps to reproduce the issue (if applicable)

  1. Open React storybook
  2. Select Content block cards - with videos
  3. Click one of the videos to trigger overlay

Release date (if applicable)

No response

Code of Conduct

@RichKummer RichKummer added bug Something isn't working package: react Work necessary for the Carbon for IBM.com react components package labels Feb 15, 2022
@jeffchew jeffchew added the dev Needs some dev work label Feb 15, 2022
@ljcarot ljcarot added the severity 3 Affects minor functionality, has a workaround label Feb 15, 2022
@stale
Copy link

stale bot commented Apr 19, 2022

We've marked this issue as stale because there hasn't been any activity for 60 days. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale
Copy link

stale bot commented May 27, 2023

We've marked this issue as stale because there hasn't been any activity for 60 days. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label May 27, 2023
@andy-blum andy-blum closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev Needs some dev work hacktoberfest inactive package: react Work necessary for the Carbon for IBM.com react components package severity 3 Affects minor functionality, has a workaround
Projects
Status: Done
Development

No branches or pull requests

7 participants